* [PATCH 6/6] extsearchidx: ck_existing: set $OID for warning context
2020-12-08 21:21 5% [PATCH 0/6] minor internal consistency things Eric Wong
@ 2020-12-08 21:21 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-12-08 21:21 UTC (permalink / raw)
To: meta
The content_hash() hash in the same scope may trigger warnings
for a given blob, so ensure we correctly report the blob where
it happens.
---
lib/PublicInbox/ExtSearchIdx.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index c82d1633..11f7786d 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -222,6 +222,8 @@ sub ck_existing { # git->cat_async callback
if ($type eq 'missing') {
_blob_missing($req);
} elsif (!is_bad_blob($oid, $type, $size, $smsg->{blob})) {
+ my $self = $req->{self} // die 'BUG: {self} missing';
+ local $self->{current_info} = "$self->{current_info} $oid";
my $cur = PublicInbox::Eml->new($bref);
if (content_hash($cur) eq $req->{chash}) {
push @{$req->{indexed}}, $smsg; # for do_xpost
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] minor internal consistency things
@ 2020-12-08 21:21 5% Eric Wong
2020-12-08 21:21 7% ` [PATCH 6/6] extsearchidx: ck_existing: set $OID for warning context Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-12-08 21:21 UTC (permalink / raw)
To: meta
Some more changes because the codebase needs to grow to
support client-side tooling and JMAP.
Lack of static type-checking means we need to be more consistent
with naming conventions to avoid confusing my easily-confused
mind.
Eric Wong (6):
treewide: replace {-inbox} with {ibx} for consistency
nntp: replace {ng} with {ibx} for consistency
rename {pi_config} fields to {pi_cfg}
extindex: do not use current dir like -index does
admin: resolve_repo_dir => resolve_inboxdir
extsearchidx: ck_existing: set $OID for warning context
Documentation/mknews.perl | 4 +-
examples/cgit.psgi | 4 +-
lib/PublicInbox/Admin.pm | 8 +-
lib/PublicInbox/Cgit.pm | 24 +++---
lib/PublicInbox/Config.pm | 2 +-
lib/PublicInbox/ExtMsg.pm | 18 ++---
lib/PublicInbox/ExtSearchIdx.pm | 2 +
lib/PublicInbox/Feed.pm | 6 +-
lib/PublicInbox/Filter/RubyLang.pm | 2 +-
lib/PublicInbox/GzipFilter.pm | 4 +-
lib/PublicInbox/IMAPD.pm | 28 +++----
lib/PublicInbox/Inbox.pm | 10 +--
lib/PublicInbox/InboxIdle.pm | 9 +--
lib/PublicInbox/InboxWritable.pm | 2 +-
lib/PublicInbox/MDA.pm | 4 +-
lib/PublicInbox/ManifestJsGz.pm | 2 +-
lib/PublicInbox/Mbox.pm | 30 +++----
lib/PublicInbox/MboxGz.pm | 4 +-
lib/PublicInbox/NNTP.pm | 124 ++++++++++++++---------------
lib/PublicInbox/NNTPD.pm | 16 ++--
lib/PublicInbox/NewsWWW.pm | 15 ++--
lib/PublicInbox/Qspawn.pm | 4 +-
lib/PublicInbox/SearchThread.pm | 4 +-
lib/PublicInbox/SearchView.pm | 14 ++--
lib/PublicInbox/Spamcheck.pm | 4 +-
lib/PublicInbox/Unsubscribe.pm | 6 +-
lib/PublicInbox/View.pm | 22 ++---
lib/PublicInbox/ViewVCS.pm | 2 +-
lib/PublicInbox/WWW.pm | 51 ++++++------
lib/PublicInbox/Watch.pm | 20 ++---
lib/PublicInbox/WwwAltId.pm | 2 +-
lib/PublicInbox/WwwAtomStream.pm | 10 +--
lib/PublicInbox/WwwAttach.pm | 10 +--
lib/PublicInbox/WwwListing.pm | 4 +-
lib/PublicInbox/WwwStream.pm | 12 +--
lib/PublicInbox/WwwText.pm | 12 +--
script/public-inbox-index | 1 +
script/public-inbox-learn | 8 +-
script/public-inbox-mda | 8 +-
scripts/import_slrnspool | 4 +-
t/admin.t | 28 ++++---
t/feed.t | 6 +-
t/filter_rubylang.t | 2 +-
t/imapd.t | 4 +-
t/inbox_idle.t | 8 +-
t/mda_filter_rubylang.t | 4 +-
t/nntp.t | 12 +--
t/psgi_mount.t | 6 +-
t/psgi_search.t | 6 +-
t/psgi_v2.t | 11 ++-
t/watch_filter_rubylang.t | 10 +--
t/watch_maildir.t | 26 +++---
t/watch_maildir_v2.t | 48 +++++------
t/watch_multiple_headers.t | 8 +-
xt/cmp-msgview.t | 2 +-
xt/perf-msgview.t | 2 +-
xt/perf-threading.t | 2 +-
57 files changed, 352 insertions(+), 349 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-12-08 21:21 5% [PATCH 0/6] minor internal consistency things Eric Wong
2020-12-08 21:21 7% ` [PATCH 6/6] extsearchidx: ck_existing: set $OID for warning context Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).