* [PATCH 5/8] extindex: minor cost reductions
2021-10-10 14:25 6% [PATCH 0/8] extindex and then some Eric Wong
@ 2021-10-10 14:25 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-10 14:25 UTC (permalink / raw)
To: meta
Don't bother decoding the 20-byte SHA-1 to a 40-byte hex value
since we don't read it, anyways. We can also use the on-stack
ibx->eidx_key value instead of dispatching the method again.
---
lib/PublicInbox/ExtSearchIdx.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 04948b8b..42488e12 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -902,15 +902,14 @@ DELETE FROM xref3 WHERE ibx_id = ? AND xnum = ? AND oidbin = ?
$del->execute;
# get_xref3 over-fetches, but this is a rare path:
- my $xr3 = $self->{oidx}->get_xref3($docid);
+ my $xr3 = $self->{oidx}->get_xref3($docid, 1);
my $idx = $self->idx_shard($docid);
if (scalar(@$xr3) == 0) { # all gone
$self->{oidx}->delete_by_num($docid);
$self->{oidx}->eidxq_del($docid);
$idx->ipc_do('xdb_remove', $docid);
} else { # enqueue for reindex of remaining messages
- $idx->ipc_do('remove_eidx_info',
- $docid, $ibx->eidx_key);
+ $idx->ipc_do('remove_eidx_info', $docid, $ekey);
$self->{oidx}->eidxq_add($docid); # yes, add
}
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/8] extindex and then some...
@ 2021-10-10 14:25 6% Eric Wong
2021-10-10 14:25 7% ` [PATCH 5/8] extindex: minor cost reductions Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-10-10 14:25 UTC (permalink / raw)
To: meta
One notable fix for -extindex --gc, a couple of minor things
here and there. Still need to speed up --reindex...
Eric Wong (8):
lei_to_mail: show --output on augment progress failure
admin: add '# ' prefix for progress messages
set nodatacow on more SQLite files
extindex: speed up Xapian cleanup in --gc
extindex: minor cost reductions
extindex: --gc doesn't touch ghost entries
lei/store: keep ".err-XXXX" in stderr tmpfile
extindex: sync each inbox before checking for missed messages
lib/PublicInbox/Admin.pm | 2 +-
lib/PublicInbox/ExtSearchIdx.pm | 51 +++++++++++++++++++++------------
lib/PublicInbox/LeiStore.pm | 2 +-
lib/PublicInbox/LeiToMail.pm | 2 +-
lib/PublicInbox/Over.pm | 4 ++-
lib/PublicInbox/SearchIdx.pm | 3 ++
lib/PublicInbox/SharedKV.pm | 3 +-
7 files changed, 43 insertions(+), 24 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-10 14:25 6% [PATCH 0/8] extindex and then some Eric Wong
2021-10-10 14:25 7% ` [PATCH 5/8] extindex: minor cost reductions Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).