* [PATCH 3/4] extindex: add undocumented --no-scan switch
2020-12-26 10:16 6% [PATCH 0/4] extindex: more fixes and usability things Eric Wong
@ 2020-12-26 10:16 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-12-26 10:16 UTC (permalink / raw)
To: meta
This makes diagnosing --watch problems easier when there's
50K inboxes by avoiding the lengthy scan (which is the reason
--watch exists in the first place).
---
lib/PublicInbox/ExtSearchIdx.pm | 8 +++++---
script/public-inbox-extindex | 4 ++--
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 778154a5..07e64698 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -881,9 +881,11 @@ sub eidx_sync { # main entry point
}
# don't use $_ here, it'll get clobbered by reindex_checkpoint
- for my $ibx (@{$self->{ibx_list}}) {
- last if $sync->{quit};
- sync_inbox($self, $sync, $ibx);
+ if ($opt->{scan} // 1) {
+ for my $ibx (@{$self->{ibx_list}}) {
+ last if $sync->{quit};
+ sync_inbox($self, $sync, $ibx);
+ }
}
$self->{oidx}->rethread_done($opt) unless $sync->{quit};
eidxq_process($self, $sync) unless $sync->{quit};
diff --git a/script/public-inbox-extindex b/script/public-inbox-extindex
index 17986f60..f4ffda4b 100644
--- a/script/public-inbox-extindex
+++ b/script/public-inbox-extindex
@@ -23,12 +23,12 @@ usage: public-inbox-extindex [options] EXTINDEX_DIR [INBOX_DIR]
BYTES may use `k', `m', and `g' suffixes (e.g. `10m' for 10 megabytes)
See public-inbox-extindex(1) man page for full documentation.
EOF
-my $opt = { quiet => -1, compact => 0, max_size => undef, fsync => 1 };
+my $opt = { quiet => -1, compact => 0, fsync => 1, scan => 1 };
GetOptions($opt, qw(verbose|v+ reindex rethread compact|c+ jobs|j=i
fsync|sync!
indexlevel|index-level|L=s max_size|max-size=s
batch_size|batch-size=s
- gc commit-interval=i watch
+ gc commit-interval=i watch scan!
all help|h))
or die $help;
if ($opt->{help}) { print $help; exit 0 };
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] extindex: more fixes and usability things
@ 2020-12-26 10:16 6% Eric Wong
2020-12-26 10:16 7% ` [PATCH 3/4] extindex: add undocumented --no-scan switch Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-12-26 10:16 UTC (permalink / raw)
To: meta
--watch seems nice, and "--watch --all" (or just "--all")
without having to specify the pathname of the extindex
is nice, too.
It still needs to write extindex.all.topdir if none is
configured and a section 1 manpage...
Eric Wong (4):
extindex: various --watch signal handling fixes
extindex: enable autoflush on STDOUT/STDERR
extindex: add undocumented --no-scan switch
extindex: allow using --all without EXTINDEX_DIR
lib/PublicInbox/ExtSearchIdx.pm | 18 ++++++++++++++----
script/public-inbox-extindex | 21 +++++++++++++++------
2 files changed, 29 insertions(+), 10 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-12-26 10:16 6% [PATCH 0/4] extindex: more fixes and usability things Eric Wong
2020-12-26 10:16 7% ` [PATCH 3/4] extindex: add undocumented --no-scan switch Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).