user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 1/2] examples: remove X-Forwarded-For mentions
  2016-07-03  1:21  6% [PATCH 0/2] varnish tweaks and such Eric Wong
@ 2016-07-03  1:21  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-07-03  1:21 UTC (permalink / raw)
  To: meta

We don't need to care about client IPs anywhere.
---
 examples/public-inbox.psgi | 2 +-
 examples/varnish-4.vcl     | 8 --------
 script/public-inbox.cgi    | 2 +-
 3 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/examples/public-inbox.psgi b/examples/public-inbox.psgi
index 11e2a6e..e97f917 100644
--- a/examples/public-inbox.psgi
+++ b/examples/public-inbox.psgi
@@ -29,7 +29,7 @@ builder {
 
 	# Enable to ensure redirects and Atom feed URLs are generated
 	# properly when running behind a reverse proxy server which
-	# sets X-Forwarded-For and X-Forwarded-Proto request headers.
+	# sets the X-Forwarded-Proto request header.
 	# See Plack::Middleware::ReverseProxy documentation for details
 	eval { enable 'ReverseProxy' };
 	$@ and warn
diff --git a/examples/varnish-4.vcl b/examples/varnish-4.vcl
index 7439679..999f954 100644
--- a/examples/varnish-4.vcl
+++ b/examples/varnish-4.vcl
@@ -15,14 +15,6 @@ backend default {
 }
 
 sub vcl_recv {
-	if (req.restarts == 0) {
-		if (req.http.x-forwarded-for) {
-			set req.http.X-Forwarded-For =
-			req.http.X-Forwarded-For + ", " + client.ip;
-		} else {
-			set req.http.X-Forwarded-For = client.ip;
-		}
-	}
 	if (req.method != "GET" &&
 			req.method != "HEAD" &&
 			req.method != "PUT" &&
diff --git a/script/public-inbox.cgi b/script/public-inbox.cgi
index 5b2aefe..2b7f737 100755
--- a/script/public-inbox.cgi
+++ b/script/public-inbox.cgi
@@ -20,7 +20,7 @@ my $app = builder {
 
 	# Enable to ensure redirects and Atom feed URLs are generated
 	# properly when running behind a reverse proxy server which
-	# sets X-Forwarded-For and X-Forwarded-Proto request headers.
+	# sets the X-Forwarded-Proto request header.
 	# See Plack::Middleware::ReverseProxy documentation for details
 	# enable 'ReverseProxy';
 
-- 
EW


^ permalink raw reply	[relevance 7%]

* [PATCH 0/2] varnish tweaks and such
@ 2016-07-03  1:21  6% Eric Wong
  2016-07-03  1:21  7% ` [PATCH 1/2] examples: remove X-Forwarded-For mentions Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-07-03  1:21 UTC (permalink / raw)
  To: meta

Less configuration and more explanation is better :)

Eric Wong (2):
      examples: remove X-Forwarded-For mentions
      examples/varnish-4.vcl: comments and tweaks

 examples/public-inbox.psgi |  2 +-
 examples/varnish-4.vcl     | 34 ++++++++++++++--------------------
 script/public-inbox.cgi    |  2 +-
 3 files changed, 16 insertions(+), 22 deletions(-)

^ permalink raw reply	[relevance 6%]

Results 1-2 of 2 | reverse | sort options + mbox downloads above
-- links below jump to the message on this page --
2016-07-03  1:21  6% [PATCH 0/2] varnish tweaks and such Eric Wong
2016-07-03  1:21  7% ` [PATCH 1/2] examples: remove X-Forwarded-For mentions Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).