* [PATCH 1/2] eml: avoid anonymous __WARN__ sub for encode/decode
2024-02-13 9:42 6% [PATCH 0/2] eml: allocation reductions Eric Wong
@ 2024-02-13 9:42 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2024-02-13 9:42 UTC (permalink / raw)
To: meta
Repeatedly allocating an anonymous sub is an expensive operation
and a potential source of leaks in older Perl. Instead,
`local'-ize a global and use a permanent sub to workaround the
old Encode 2.87..3.12 leak.
---
lib/PublicInbox/Eml.pm | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/lib/PublicInbox/Eml.pm b/lib/PublicInbox/Eml.pm
index 24060ec8..56aec1e5 100644
--- a/lib/PublicInbox/Eml.pm
+++ b/lib/PublicInbox/Eml.pm
@@ -334,6 +334,11 @@ sub body_set {
undef;
}
+# workaround https://rt.cpan.org/Public/Bug/Display.html?id=139622
+# Encode 2.87..3.12 leaks on croak, so we defer and croak ourselves
+our @enc_warn;
+my $enc_warn = sub { push @enc_warn, @_ };
+
sub body_str_set {
my ($self, $str) = @_;
my $cs = ct($self)->{attributes}->{charset} //
@@ -341,10 +346,10 @@ sub body_str_set {
my $enc = find_encoding($cs) // croak "unknown encoding `$cs'";
my $tmp;
{
- my @w;
- local $SIG{__WARN__} = sub { push @w, @_ };
+ local @enc_warn;
+ local $SIG{__WARN__} = $enc_warn;
$tmp = $enc->encode($str, Encode::FB_WARN);
- croak(@w) if @w;
+ croak(@enc_warn) if @enc_warn;
};
body_set($self, \$tmp);
}
@@ -471,11 +476,10 @@ sub body_str {
};
my $enc = find_encoding($cs) or croak "unknown encoding `$cs'";
my $tmp = body($self);
- # workaround https://rt.cpan.org/Public/Bug/Display.html?id=139622
- my @w;
- local $SIG{__WARN__} = sub { push @w, @_ };
+ local @enc_warn;
+ local $SIG{__WARN__} = $enc_warn;
my $ret = $enc->decode($tmp, Encode::FB_WARN);
- croak(@w) if @w;
+ croak(@enc_warn) if @enc_warn;
$ret;
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] eml: allocation reductions
@ 2024-02-13 9:42 6% Eric Wong
2024-02-13 9:42 7% ` [PATCH 1/2] eml: avoid anonymous __WARN__ sub for encode/decode Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2024-02-13 9:42 UTC (permalink / raw)
To: meta
1/2 is obvious, 2/2 is aspirational dream territory...
(been dreaming up a faster, alternative run-time for Perl :P)
Eric Wong (2):
eml: avoid anonymous __WARN__ sub for encode/decode
eml: reuse ->decode buffer
lib/PublicInbox/Eml.pm | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2024-02-13 9:42 6% [PATCH 0/2] eml: allocation reductions Eric Wong
2024-02-13 9:42 7% ` [PATCH 1/2] eml: avoid anonymous __WARN__ sub for encode/decode Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).