* [PATCH 2/8] drop binmode usage
2020-07-17 6:31 6% [PATCH 0/8] indexing cleanup and code reduction Eric Wong
@ 2020-07-17 6:31 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-07-17 6:31 UTC (permalink / raw)
To: meta
We only support Unix-like platforms where binmode (":raw") is
the default anyways, and v5.10 semantics means it won't do
unicode_strings (unlike v5.12). So save some lines of code.
---
lib/PublicInbox/Import.pm | 2 --
lib/PublicInbox/SearchIdxShard.pm | 2 --
2 files changed, 4 deletions(-)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index fb813159..b61d4b31 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -73,8 +73,6 @@ sub gfi_start {
$self->{out} = $out_w;
$self->{pid} = $pid;
$self->{nchg} = 0;
- binmode $out_w, ':raw' or die "binmode :raw failed: $!";
- binmode $in_r, ':raw' or die "binmode :raw failed: $!";
($in_r, $out_w);
}
diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm
index baf7352a..b51d148b 100644
--- a/lib/PublicInbox/SearchIdxShard.pm
+++ b/lib/PublicInbox/SearchIdxShard.pm
@@ -26,8 +26,6 @@ sub spawn_worker {
my ($self, $v2w, $shard) = @_;
my ($r, $w);
pipe($r, $w) or die "pipe failed: $!\n";
- binmode $r, ':raw';
- binmode $w, ':raw';
$w->autoflush(1);
my $pid = fork;
defined $pid or die "fork failed: $!\n";
^ permalink raw reply related [relevance 7%]
* [PATCH 0/8] indexing cleanup and code reduction
@ 2020-07-17 6:31 6% Eric Wong
2020-07-17 6:31 7% ` [PATCH 2/8] drop binmode usage Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-07-17 6:31 UTC (permalink / raw)
To: meta
Some bigger indexing updates coming, but first we can
reduce allocations and get rid of some overly complicated
unindexing logic.
Eric Wong (8):
v2: use v5.10.1, parent.pm, drop warnings
drop binmode usage
import: use common capitalization for filtering headers
with_umask: pass args to callback
overidx: each_by_mid: pass self and args to callbacks
overidx: favor non-OO sub dispatch for internal subs
searchidx: use v5.10.1, parent.pm, drop warnings
search: simplify unindexing
lib/PublicInbox/Import.pm | 4 +-
lib/PublicInbox/InboxWritable.pm | 42 ++++---
lib/PublicInbox/OverIdx.pm | 126 +++++++++++----------
lib/PublicInbox/SearchIdx.pm | 178 ++++++++++++------------------
lib/PublicInbox/SearchIdxShard.pm | 12 +-
lib/PublicInbox/V2Writable.pm | 116 +++++++++----------
lib/PublicInbox/Xapcmd.pm | 35 +++---
t/search.t | 6 +-
8 files changed, 246 insertions(+), 273 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-07-17 6:31 6% [PATCH 0/8] indexing cleanup and code reduction Eric Wong
2020-07-17 6:31 7% ` [PATCH 2/8] drop binmode usage Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).