* Re: [PATCH 5/5] Fix some typos/grammar/errors in docs and comments
@ 2023-08-28 21:11 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2023-08-28 21:11 UTC (permalink / raw)
To: Štěpán Němec; +Cc: meta
Štěpán Němec <stepnem@smrk.net> wrote:
> Please note the FIXME added in this patch: I lacked the confidence to
> repair that paragraph on my own.
> --- a/Documentation/public-inbox-daemon.pod
> +++ b/Documentation/public-inbox-daemon.pod
> @@ -101,6 +101,8 @@ Default: 1
> The default TLS certificate for HTTPS, IMAPS, NNTPS, POP3S and/or STARTTLS
> support if the C<cert> option is not given with C<--listen>.
>
> +=for comment FIXME this paragraph needs repair
> +
> Well-known TCP ports automatically get TLS or STARTTLS support
> If using systemd-compatible socket activation and a TCP listener
> on port well-known ports (563 is inherited, it is automatically
Thanks for noticing, my brain spews gibberish much of the time :x
Perhaps something like the following is clearer?
-----8<-----
Subject: [PATCH] doc: daemon: clarify TLS and well-known ports
Reported-by: Štěpán Němec <stepnem@smrk.net>
---
Documentation/public-inbox-daemon.pod | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/Documentation/public-inbox-daemon.pod b/Documentation/public-inbox-daemon.pod
index c5c88bdd..187c17d0 100644
--- a/Documentation/public-inbox-daemon.pod
+++ b/Documentation/public-inbox-daemon.pod
@@ -101,14 +101,11 @@ Default: 1
The default TLS certificate for HTTPS, IMAPS, NNTPS, POP3S and/or STARTTLS
support if the C<cert> option is not given with C<--listen>.
-=for comment FIXME this paragraph needs repair
-
-Well-known TCP ports automatically get TLS or STARTTLS support
-If using systemd-compatible socket activation and a TCP listener
-on port well-known ports (563 is inherited, it is automatically
-NNTPS when this option is given. When a listener on port 119 is
-inherited and this option is given, it automatically gets
-STARTTLS support.
+Well-known TCP ports automatically get TLS or STARTTLS support if using
+systemd-compatible socket activation. That is, ports 443, 563, 993, and
+995 support HTTPS, NNTPS, IMAPS, and POP3S, respectively; while ports
+110, 119, and 143 support STARTTLS on POP3, NNTP, and IMAP,
+respectively.
=item --key /path/to/key
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-08-28 10:42 [PATCH 1/5] ci/profiles.sh: fix case matching logic Štěpán Němec
2023-08-28 10:42 ` [PATCH 5/5] Fix some typos/grammar/errors in docs and comments Štěpán Němec
2023-08-28 21:11 7% ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).