user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] daemon: ignore SIGWINCH when connected to terminal
@ 2016-05-23  1:02  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-05-23  1:02 UTC (permalink / raw)
  To: meta

Users may change terminal sizes if the process is connected to a
terminal, so we can't reasonably expect SIGWINCH to work as
intended.
---
 lib/PublicInbox/Daemon.pm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm
index 3d895b0..b64ec87 100644
--- a/lib/PublicInbox/Daemon.pm
+++ b/lib/PublicInbox/Daemon.pm
@@ -375,7 +375,13 @@ sub master_loop {
 				exit if $quit++;
 				kill_workers($s);
 			} elsif ($s eq 'WINCH') {
-				$worker_processes = 0;
+				if (-t STDIN || -t STDOUT || -t STDERR) {
+					warn
+"ignoring SIGWINCH while connected to terminal\n";
+					$SIG{WINCH} = 'IGNORE';
+				} else {
+					$worker_processes = 0;
+				}
 			} elsif ($s eq 'HUP') {
 				$worker_processes = $set_workers;
 				kill_workers($s);

^ permalink raw reply	[relevance 7%]

Results 1-1 of 1 | reverse | sort options + mbox downloads above
-- links below jump to the message on this page --
2016-05-23  1:02  7% [PATCH] daemon: ignore SIGWINCH when connected to terminal Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).