* [PATCH 1/2] daemon: die properly when Socket6 is missing
2019-02-06 11:07 5% [PATCH 0/2] try harder to avoid Socket6 dependency Eric Wong
@ 2019-02-06 11:07 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-02-06 11:07 UTC (permalink / raw)
To: meta
We need to keep Unix-socket-only httpd instances working
without Socket6. This fixes t/httpd-unix.t with Socket6
uninstalled.
---
lib/PublicInbox/Daemon.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm
index 6aa4a19..033dd98 100644
--- a/lib/PublicInbox/Daemon.pm
+++ b/lib/PublicInbox/Daemon.pm
@@ -241,8 +241,8 @@ sub unpack_ipv6 ($) {
# (perl-modules-5.24 in Debian)
# SpamAssassin and Net::Server use Socket6, so it may be installed
- # on our system, already:
- eval { require Socket6 } or return ('???-Socket6-missing', 0);
+ # on our system, already (otherwise die):
+ require Socket6;
my ($port, $host) = Socket6::unpack_sockaddr_in6($addr);
$host = Socket6::inet_ntop(Socket6::AF_INET6(), $host);
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] try harder to avoid Socket6 dependency
@ 2019-02-06 11:07 5% Eric Wong
2019-02-06 11:07 7% ` [PATCH 1/2] daemon: die properly when Socket6 is missing Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-02-06 11:07 UTC (permalink / raw)
To: meta
Since I reckon Perl 5.14+ is pretty common, favoring the
bundled Socket.pm is advantageous in reducing installation
overhead and memory use, since we already rely on "Socket"
being loaded.
*** BLURB HERE ***
Eric Wong (2):
daemon: die properly when Socket6 is missing
daemon: favor Socket.pm in Perl 5.14+ for IPv6
INSTALL | 3 ++-
lib/PublicInbox/Daemon.pm | 21 ++++++++++++++-------
2 files changed, 16 insertions(+), 8 deletions(-)
--
EW
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-02-06 11:07 5% [PATCH 0/2] try harder to avoid Socket6 dependency Eric Wong
2019-02-06 11:07 7% ` [PATCH 1/2] daemon: die properly when Socket6 is missing Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).