* [PATCH 6/6] contentid: ignore duplicate References: headers
2020-01-23 23:05 6% [PATCH 0/6] shorten and simplify uniq logic Eric Wong
@ 2020-01-23 23:05 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-23 23:05 UTC (permalink / raw)
To: meta
OverIdx::parse_references already skips duplicate
References (which we use in SearchThread for rendering).
So there's no reason for our content deduplication logic
to care if a Message-Id in the Reference header is mentioned
twice.
---
lib/PublicInbox/ContentId.pm | 3 +--
lib/PublicInbox/OverIdx.pm | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/ContentId.pm b/lib/PublicInbox/ContentId.pm
index 0c4a8678..65691593 100644
--- a/lib/PublicInbox/ContentId.pm
+++ b/lib/PublicInbox/ContentId.pm
@@ -64,8 +64,7 @@ sub content_digest ($) {
# if we got here, we've already got Message-ID reuse
my %seen = map { $_ => 1 } @{mids($hdr)};
foreach my $mid (@{references($hdr)}) {
- next if $seen{$mid};
- $dig->add("ref\0$mid\0");
+ $dig->add("ref\0$mid\0") unless $seen{$mid}++;
}
# Only use Sender: if From is not present
diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 189bd21d..5f1007aa 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -230,8 +230,7 @@ sub parse_references ($$$) {
warn "References: <$ref> too long, ignoring\n";
next;
}
- next if $seen{$ref}++;
- push @keep, $ref;
+ push(@keep, $ref) unless $seen{$ref}++;
}
$smsg->{references} = '<'.join('> <', @keep).'>' if @keep;
\@keep;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] shorten and simplify uniq logic
@ 2020-01-23 23:05 6% Eric Wong
2020-01-23 23:05 7% ` [PATCH 6/6] contentid: ignore duplicate References: headers Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-23 23:05 UTC (permalink / raw)
To: meta
I noticed List::Util 1.45+ includes a new "uniq()" sub, but
that's only distributed with Perl as of 5.26+.
Since we care about supporting older versions of Perl, I still
took the opportunity to simplify some of our own similar logic
for making things unique. It turns out only Inbox->nntp_url
really benefits from List::Util::uniq at the moment, but there's
some small simplifications to be had along the way.
Eric Wong (6):
contentid: use map to generate %seen for Message-Ids
nntp: simplify setting X-Alt-Message-ID
inbox: simplify filtering for duplicate NNTP URLs
mid: shorten uniq_mids logic
wwwstream: shorten cloneurl uniquification
contentid: ignore duplicate References: headers
lib/PublicInbox/ContentId.pm | 12 ++++--------
lib/PublicInbox/Inbox.pm | 11 +++++------
lib/PublicInbox/MID.pm | 4 +---
lib/PublicInbox/NNTP.pm | 5 +----
lib/PublicInbox/OverIdx.pm | 3 +--
lib/PublicInbox/WwwStream.pm | 8 +++-----
6 files changed, 15 insertions(+), 28 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-23 23:05 6% [PATCH 0/6] shorten and simplify uniq logic Eric Wong
2020-01-23 23:05 7% ` [PATCH 6/6] contentid: ignore duplicate References: headers Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).