* [PATCH 1/5] config: remove {-cgitrc_unparsed} field
2022-10-08 8:24 6% [PATCH 0/5] www: some coderepo stuff Eric Wong
@ 2022-10-08 8:24 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-10-08 8:24 UTC (permalink / raw)
To: meta
This field has been unneeded since commit 6890430df808
(cgit: fix fallout from lazy coderepo loading, 2021-03-18)
---
lib/PublicInbox/Config.pm | 2 +-
lib/PublicInbox/WwwCoderepo.pm | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 42bd9438..5cdf182e 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -46,7 +46,6 @@ sub new {
$self->{-no_obfuscate} = {};
$self->{-limiters} = {};
$self->{-code_repos} = {}; # nick => PublicInbox::Git object
- $self->{-cgitrc_unparsed} = $self->{'publicinbox.cgitrc'};
if (my $no = delete $self->{'publicinbox.noobfuscate'}) {
$no = _array($no);
@@ -277,6 +276,7 @@ sub scan_projects_coderepo ($$$) {
sub parse_cgitrc {
my ($self, $cgitrc, $nesting) = @_;
+ $cgitrc //= $self->{'publicinbox.cgitrc'};
if ($nesting == 0) {
# defaults:
my %s = map { $_ => 1 } qw(/cgit.css /cgit.png
diff --git a/lib/PublicInbox/WwwCoderepo.pm b/lib/PublicInbox/WwwCoderepo.pm
index 6c119b28..d491bba2 100644
--- a/lib/PublicInbox/WwwCoderepo.pm
+++ b/lib/PublicInbox/WwwCoderepo.pm
@@ -23,9 +23,9 @@ sub prepare_coderepos {
my $pi_cfg = $self->{pi_cfg};
# TODO: support gitweb and other repository viewers?
- if (defined(my $cgitrc = $pi_cfg->{-cgitrc_unparsed})) {
- $pi_cfg->parse_cgitrc($cgitrc, 0);
- }
+ defined($pi_cfg->{'publicinbox.cgitrc'}) and
+ $pi_cfg->parse_cgitrc(undef, 0);
+
my $code_repos = $pi_cfg->{-code_repos};
for my $k (grep(/\Acoderepo\.(?:.+)\.dir\z/, keys %$pi_cfg)) {
$k = substr($k, length('coderepo.'), -length('.dir'));
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] www: some coderepo stuff
@ 2022-10-08 8:24 6% Eric Wong
2022-10-08 8:24 7% ` [PATCH 1/5] config: remove {-cgitrc_unparsed} field Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-10-08 8:24 UTC (permalink / raw)
To: meta
5/5 is clearly incomplete, but it's nicer than broken
links before in $CODEREPO/$OID/s/ endpoints.
Deployed to https://yhbt.net/lore/git.git/<COMMIT_OID>/s/#related
Eric Wong (5):
config: remove {-cgitrc_unparsed} field
www_coderepo: wire up snapshots from summary
www_coderepo: update blurb on the goal/purpose of this
www: cgit: fix fallback to WwwCoderepo on array responses
www_coderepo: allow searching one extindex|inbox
Documentation/public-inbox-config.pod | 4 +++
lib/PublicInbox/Config.pm | 9 ++++-
lib/PublicInbox/GitHTTPBackend.pm | 6 +++-
lib/PublicInbox/Inbox.pm | 3 +-
lib/PublicInbox/RepoSnapshot.pm | 4 ++-
lib/PublicInbox/ViewVCS.pm | 31 ++++++++++++++---
lib/PublicInbox/WwwCoderepo.pm | 50 +++++++++++++++++++++++----
t/solver_git.t | 6 ++++
8 files changed, 99 insertions(+), 14 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-10-08 8:24 6% [PATCH 0/5] www: some coderepo stuff Eric Wong
2022-10-08 8:24 7% ` [PATCH 1/5] config: remove {-cgitrc_unparsed} field Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).