user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] config: describe order dependency in cgitrc parsing
@ 2023-04-06 21:02  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2023-04-06 21:02 UTC (permalink / raw)
  To: meta

I just had to do a double-take here and look back at cgit.c
to see the ordering dependency wasn't a bug I introduced,
but mimicking what cgit does.
---
 lib/PublicInbox/Config.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index e095ecd1..df488f23 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -318,6 +318,8 @@ sub parse_cgitrc {
 			$k =~ tr/-/_/;
 			$self->{"-cgit_$k"} = $v;
 		} elsif (m!\Ascan-path=(.+)\z!) {
+			# this depends on being after project-list in the
+			# config file, just like cgit.c
 			if (defined(my $list = $self->{-cgit_project_list})) {
 				scan_projects_coderepo($self, $list, $1);
 			} else {

^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-04-06 21:02  7% [PATCH] config: describe order dependency in cgitrc parsing Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).