user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 3/6] altid: use msgmap at compile time
  2020-01-05 23:23  5% [PATCH 0/6] various cleanups around use/require Eric Wong
@ 2020-01-05 23:23  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-05 23:23 UTC (permalink / raw)
  To: meta

AltId requires Msgmap to work, which requires SQLite.  Search
also requires SQLite3 (for Over), nowadays, so there's no reason
for us to lazy-load Msgmap and SQLite anymore.
---
 lib/PublicInbox/AltId.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/PublicInbox/AltId.pm b/lib/PublicInbox/AltId.pm
index b4daaed2..6b03d603 100644
--- a/lib/PublicInbox/AltId.pm
+++ b/lib/PublicInbox/AltId.pm
@@ -13,6 +13,7 @@ package PublicInbox::AltId;
 use strict;
 use warnings;
 use URI::Escape qw(uri_unescape);
+use PublicInbox::Msgmap;
 
 # spec: TYPE:PREFIX:param1=value1&param2=value2&...
 # The PREFIX will be a searchable boolean prefix in Xapian
@@ -22,8 +23,6 @@ sub new {
 	my ($type, $prefix, $query) = split(/:/, $spec, 3);
 	$type eq 'serial' or die "non-serial not supported, yet\n";
 
-	require PublicInbox::Msgmap;
-
 	my %params = map {
 		my ($k, $v) = split(/=/, uri_unescape($_), 2);
 		$v = '' unless defined $v;

^ permalink raw reply related	[relevance 7%]

* [PATCH 0/6] various cleanups around use/require
@ 2020-01-05 23:23  5% Eric Wong
  2020-01-05 23:23  7% ` [PATCH 3/6] altid: use msgmap at compile time Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-05 23:23 UTC (permalink / raw)
  To: meta

We've accumulated some cruft over the years.  Lets get rid of
some of it and find places where we can help Perl figure more
stuff out at compile-time rather than run-time.

Eric Wong (6):
  hval: export prurl and add prototype
  view: update POSIX::strftime usage
  altid: use msgmap at compile time
  admin: do not lazy-load Inbox or Config packages
  treewide: "require" + "use" cleanup and docs
  syscall: modernize away from pre-Perl-5.6 conventions

 Makefile.PL                        |  2 +-
 lib/PublicInbox/Admin.pm           |  4 ++--
 lib/PublicInbox/AltId.pm           |  3 +--
 lib/PublicInbox/Config.pm          |  2 +-
 lib/PublicInbox/DS.pm              |  5 ++---
 lib/PublicInbox/Daemon.pm          |  2 +-
 lib/PublicInbox/Emergency.pm       |  2 +-
 lib/PublicInbox/ExtMsg.pm          |  5 ++---
 lib/PublicInbox/Filter/RubyLang.pm |  1 -
 lib/PublicInbox/Git.pm             |  2 +-
 lib/PublicInbox/GitHTTPBackend.pm  |  2 +-
 lib/PublicInbox/HTTP.pm            |  3 ++-
 lib/PublicInbox/HTTPD.pm           |  4 ++--
 lib/PublicInbox/Hval.pm            |  5 +++--
 lib/PublicInbox/Import.pm          |  2 +-
 lib/PublicInbox/Listener.pm        |  2 +-
 lib/PublicInbox/MboxGz.pm          |  1 -
 lib/PublicInbox/NNTPD.pm           |  2 +-
 lib/PublicInbox/NewsWWW.pm         |  3 ++-
 lib/PublicInbox/Search.pm          |  2 --
 lib/PublicInbox/SearchIdx.pm       |  2 +-
 lib/PublicInbox/SearchView.pm      |  6 +----
 lib/PublicInbox/SolverGit.pm       |  2 +-
 lib/PublicInbox/Spawn.pm           |  1 -
 lib/PublicInbox/Syscall.pm         | 35 ++++++++++++++----------------
 lib/PublicInbox/TLS.pm             |  2 --
 lib/PublicInbox/Tmpfile.pm         |  2 +-
 lib/PublicInbox/V2Writable.pm      |  2 +-
 lib/PublicInbox/View.pm            | 17 +++++++--------
 lib/PublicInbox/ViewDiff.pm        |  2 +-
 lib/PublicInbox/WatchMaildir.pm    |  2 +-
 lib/PublicInbox/WwwAtomStream.pm   |  2 +-
 lib/PublicInbox/WwwListing.pm      |  6 ++---
 lib/PublicInbox/WwwStream.pm       |  4 ++--
 lib/PublicInbox/Xapcmd.pm          |  2 +-
 script/public-inbox-convert        |  2 --
 script/public-inbox-edit           |  8 +++----
 script/public-inbox-init           |  4 ++--
 script/public-inbox-nntpd          |  4 ++--
 t/cgi.t                            |  2 --
 t/feed.t                           |  2 --
 41 files changed, 71 insertions(+), 92 deletions(-)

^ permalink raw reply	[relevance 5%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-05 23:23  5% [PATCH 0/6] various cleanups around use/require Eric Wong
2020-01-05 23:23  7% ` [PATCH 3/6] altid: use msgmap at compile time Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).