* [PATCH 2/5] allow HTTP_HOST to be '0' via defined() checks
2020-01-10 9:14 4% [PATCH 0/5] misc cleanups and bugfixes Eric Wong
@ 2020-01-10 9:14 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-10 9:14 UTC (permalink / raw)
To: meta
'0' is a valid value for HTTP_HOST, and maybe some folks
will want to hit that as port 80 where the HTTP client won't
send the ":$PORT" suffix.
---
lib/PublicInbox/Git.pm | 2 +-
lib/PublicInbox/HTTP.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 6a527f82..2aaf1866 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -300,7 +300,7 @@ sub host_prefix_url ($$) {
my ($env, $url) = @_;
return $url if index($url, '//') >= 0;
my $scheme = $env->{'psgi.url_scheme'};
- my $host_port = $env->{HTTP_HOST} ||
+ my $host_port = $env->{HTTP_HOST} //
"$env->{SERVER_NAME}:$env->{SERVER_PORT}";
"$scheme://$host_port". ($env->{SCRIPT_NAME} || '/') . $url;
}
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index a6ec1d0d..071251c6 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -155,7 +155,7 @@ sub app_dispatch {
my $env = $self->{env};
$env->{REMOTE_ADDR} = $self->{remote_addr};
$env->{REMOTE_PORT} = $self->{remote_port};
- if (my $host = $env->{HTTP_HOST}) {
+ if (defined(my $host = $env->{HTTP_HOST})) {
$host =~ s/:([0-9]+)\z// and $env->{SERVER_PORT} = $1;
$env->{SERVER_NAME} = $host;
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] misc cleanups and bugfixes
@ 2020-01-10 9:14 4% Eric Wong
2020-01-10 9:14 7% ` [PATCH 2/5] allow HTTP_HOST to be '0' via defined() checks Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-10 9:14 UTC (permalink / raw)
To: meta
Some minor things, probably unlikely to matter a lot
but we can trim some code a little.
Eric Wong (5):
inbox: use PublicInbox::Git::host_prefix_url for base_url
allow HTTP_HOST to be '0' via defined() checks
git: ->modified uses cat_async
git: remove ->commit_title method
spawn (and thus popen_rd) die on failure
lib/PublicInbox/Config.pm | 2 +-
lib/PublicInbox/Git.pm | 24 +++++++++++-------------
lib/PublicInbox/HTTP.pm | 2 +-
lib/PublicInbox/Import.pm | 2 --
lib/PublicInbox/Inbox.pm | 30 +++++++++++++-----------------
lib/PublicInbox/SearchIdx.pm | 1 -
lib/PublicInbox/Spamcheck/Spamc.pm | 1 -
lib/PublicInbox/Spawn.pm | 1 -
lib/PublicInbox/TestCommon.pm | 1 -
lib/PublicInbox/V2Writable.pm | 1 -
lib/PublicInbox/WatchMaildir.pm | 1 -
lib/PublicInbox/WwwListing.pm | 4 +---
t/check-www-inbox.perl | 1 -
t/solver_git.t | 8 +-------
14 files changed, 28 insertions(+), 51 deletions(-)
^ permalink raw reply [relevance 4%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-10 9:14 4% [PATCH 0/5] misc cleanups and bugfixes Eric Wong
2020-01-10 9:14 7% ` [PATCH 2/5] allow HTTP_HOST to be '0' via defined() checks Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).