* [PATCH 1/2] admin: index_inbox: drop unnecessary check
2021-07-30 12:18 6% [PATCH 0/2] extindex admin updates Eric Wong
@ 2021-07-30 12:18 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-07-30 12:18 UTC (permalink / raw)
To: meta
No callers pass an unblessed pathname to index_inbox,
only Inbox object refs.
---
lib/PublicInbox/Admin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm
index eb38dd8f..d5f867a2 100644
--- a/lib/PublicInbox/Admin.pm
+++ b/lib/PublicInbox/Admin.pm
@@ -247,7 +247,7 @@ sub index_inbox {
return if PublicInbox::Eml::warn_ignore(@_);
warn($idx->{current_info}, ': ', @_);
};
- if (ref($ibx) && $ibx->version == 2) {
+ if ($ibx->version == 2) {
eval { require PublicInbox::V2Writable };
die "v2 requirements not met: $@\n" if $@;
$ibx->{-creat_opt}->{nproc} = $jobs;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] extindex admin updates
@ 2021-07-30 12:18 6% Eric Wong
2021-07-30 12:18 7% ` [PATCH 1/2] admin: index_inbox: drop unnecessary check Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-07-30 12:18 UTC (permalink / raw)
To: meta
-xcpdb and -compact now support extindex directories
so resharding can and defragmenting can happen
Eric Wong (2):
admin: index_inbox: drop unnecessary check
extindex: -xcpdb and -compact support
lib/PublicInbox/Admin.pm | 42 ++++++++++++++++++++++---
lib/PublicInbox/Search.pm | 2 +-
lib/PublicInbox/V2Writable.pm | 6 ++--
lib/PublicInbox/Xapcmd.pm | 58 ++++++++++++++++++++++-------------
script/public-inbox-compact | 16 ++++++----
script/public-inbox-xcpdb | 18 ++++++-----
t/extsearch.t | 32 +++++++++++++++++++
t/indexlevels-mirror.t | 3 +-
8 files changed, 134 insertions(+), 43 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-07-30 12:18 6% [PATCH 0/2] extindex admin updates Eric Wong
2021-07-30 12:18 7% ` [PATCH 1/2] admin: index_inbox: drop unnecessary check Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).