* [PATCH 03/20] admin|xapcmd: user-facing messages say "shard"
2019-06-15 8:46 6% [PATCH 00/20] v2: use consistent terminology Eric Wong
@ 2019-06-15 8:46 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-06-15 8:46 UTC (permalink / raw)
To: meta
We're slowly getting rid of the word "partition" when it
comes to remain consistent with Xapian docs.
---
lib/PublicInbox/Admin.pm | 2 +-
lib/PublicInbox/Xapcmd.pm | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm
index 8a2f204..5549b85 100644
--- a/lib/PublicInbox/Admin.pm
+++ b/lib/PublicInbox/Admin.pm
@@ -207,7 +207,7 @@ sub index_inbox {
my $n = $v2w->{partitions};
if ($jobs != ($n + 1)) {
warn
-"Unable to respect --jobs=$jobs, inbox was created with $n partitions\n";
+"Unable to respect --jobs=$jobs, inbox was created with $n shards\n";
}
}
}
diff --git a/lib/PublicInbox/Xapcmd.pm b/lib/PublicInbox/Xapcmd.pm
index e1c6fe3..e303da9 100644
--- a/lib/PublicInbox/Xapcmd.pm
+++ b/lib/PublicInbox/Xapcmd.pm
@@ -68,11 +68,11 @@ sub commit_changes ($$$) {
my $n = $im->count_partitions;
if (defined $new_parts && $n != $new_parts) {
die
-"BUG: counted $n partitions after repartioning to $new_parts";
+"BUG: counted $n shards after resharding to $new_parts";
}
my $prev = $im->{partitions};
if ($pr && $prev != $n) {
- $pr->("partition count changed: $prev => $n\n");
+ $pr->("shard count changed: $prev => $n\n");
$im->{partitions} = $n;
}
}
@@ -177,7 +177,7 @@ sub run {
}
# we want temporary directories to be as deep as possible,
- # so v2 partitions can keep "xap$SCHEMA_VERSION" on a separate FS.
+ # so v2 shards can keep "xap$SCHEMA_VERSION" on a separate FS.
if ($v == 1) {
if (defined $new_parts) {
warn
@@ -355,9 +355,9 @@ sub cpdb ($$) {
if (ref($old) eq 'ARRAY') {
($cur_part) = ($new =~ m!xap[0-9]+/([0-9]+)\b!);
defined $cur_part or
- die "BUG: could not extract partition # from $new";
+ die "BUG: could not extract shard # from $new";
$new_parts = $opt->{reshard};
- defined $new_parts or die 'BUG: got array src w/o --partition';
+ defined $new_parts or die 'BUG: got array src w/o --reshard';
# repartitioning, M:N copy means have full read access
foreach (@$old) {
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 00/20] v2: use consistent terminology
@ 2019-06-15 8:46 6% Eric Wong
2019-06-15 8:46 7% ` [PATCH 03/20] admin|xapcmd: user-facing messages say "shard" Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-06-15 8:46 UTC (permalink / raw)
To: meta
Modern Xapian docs and code refer to multi-DB uses as "shards";
so replace the term "partition" with the term "shard". This
way, we'll minimize the learning curve for people new to
public-inbox or Xapian.
We also still had a few places where we referred to git epochs
as "partitions", so fix those up and be consistent with the
majority of our own docs and code.
Eric Wong (20):
doc: rename our Xapian "partitions" to "shards"
v2writable: update comments regarding xcpdb --reshard
admin|xapcmd: user-facing messages say "shard"
rename reference to git epochs as "partitions"
searchidxpart: start using "shard" in user-visible places
v2writable: count_partitions => count_shards
v2writable: rename {partitions} field to {shards}
tests: change messages to use "shard" instead of partition
inboxwritable: s/partitions/shards/ in local var
v2: rename SearchIdxPart => SearchIdxShard
xapcmd: update comments referencing "partitions"
search*: rename {partition} => {shard}
v2writable: avoid "part" in internal subs and fields
v2writable: rename local vars to match Xapian terminology
adminedit: "part" => "shard" for local variables
v2writable: use "epoch" consistently when referring to git repos
search: use "shard" for local variable
xapcmd: favor 'shard' over 'part' in local variables
t/xcpdb-reshard: use 'shard' term in local variables
comments: replace "partition" with "shard"
Documentation/public-inbox-v2-format.pod | 10 +-
Documentation/public-inbox-xcpdb.pod | 11 +-
MANIFEST | 2 +-
lib/PublicInbox/Admin.pm | 4 +-
lib/PublicInbox/AdminEdit.pm | 12 +-
lib/PublicInbox/Inbox.pm | 18 +--
lib/PublicInbox/InboxWritable.pm | 4 +-
lib/PublicInbox/Search.pm | 14 +--
lib/PublicInbox/SearchIdx.pm | 19 +--
.../{SearchIdxPart.pm => SearchIdxShard.pm} | 30 ++---
lib/PublicInbox/V2Writable.pm | 109 +++++++++---------
lib/PublicInbox/WWW.pm | 12 +-
lib/PublicInbox/WwwListing.pm | 2 +-
lib/PublicInbox/WwwStream.pm | 12 +-
lib/PublicInbox/Xapcmd.pm | 96 +++++++--------
t/indexlevels-mirror.t | 2 +-
t/psgi_v2.t | 2 +-
t/v2writable.t | 4 +-
t/view.t | 2 +-
t/xcpdb-reshard.t | 14 +--
20 files changed, 188 insertions(+), 191 deletions(-)
rename lib/PublicInbox/{SearchIdxPart.pm => SearchIdxShard.pm} (78%)
--
EW
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-06-15 8:46 6% [PATCH 00/20] v2: use consistent terminology Eric Wong
2019-06-15 8:46 7% ` [PATCH 03/20] admin|xapcmd: user-facing messages say "shard" Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).