* [PATCH 1/2] address: beef up the module with name list extaction
2016-06-25 9:44 6% [PATCH 0/2] www: show To/Cc destinations in conversation view Eric Wong
@ 2016-06-25 9:44 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-25 9:44 UTC (permalink / raw)
To: meta
We may remove from_name in the future.
...And disallow quotes in email addresses.
Technically I believe they're allowed, but they're definitely
uncommon and unlikely to show up in legitimate mail.
---
MANIFEST | 1 +
lib/PublicInbox/Address.pm | 13 ++++++++++++-
t/address.t | 21 +++++++++++++++++++++
3 files changed, 34 insertions(+), 1 deletion(-)
create mode 100644 t/address.t
diff --git a/MANIFEST b/MANIFEST
index 834cb5d..2156caf 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -99,6 +99,7 @@ scripts/import_slrnspool
scripts/report-spam
scripts/slrnspool2maildir
scripts/ssoma-replay
+t/address.t
t/cgi.t
t/check-www-inbox.perl
t/common.perl
diff --git a/lib/PublicInbox/Address.pm b/lib/PublicInbox/Address.pm
index 772aded..abba43d 100644
--- a/lib/PublicInbox/Address.pm
+++ b/lib/PublicInbox/Address.pm
@@ -7,7 +7,18 @@ use warnings;
# very loose regexes, here. We don't need RFC-compliance,
# just enough to make thing sanely displayable and pass to git
-sub emails { ($_[0] =~ /([^<\s,]+\@[^>\s,]+)/g) }
+sub emails { ($_[0] =~ /([\w\.\+=\-]+\@[\w\.\-]+)>?\s*(?:,\s*|\z)/g) }
+
+sub names {
+ map {
+ tr/\r\n\t/ /;
+ s/\s*<([^<]+)\z//;
+ my $e = $1;
+ s/\A['"\s]*//;
+ s/['"\s]*\z//;
+ $_ =~ /\S/ ? $_ : $e;
+ } split(/\@+[\w\.\-]+>?\s*(?:,\s*|\z)/, $_[0]);
+}
sub from_name {
my ($val) = @_;
diff --git a/t/address.t b/t/address.t
new file mode 100644
index 0000000..c488a8e
--- /dev/null
+++ b/t/address.t
@@ -0,0 +1,21 @@
+# Copyright (C) 2016 all contributors <meta@public-inbox.org>
+# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use strict;
+use warnings;
+use Test::More;
+use_ok 'PublicInbox::Address';
+
+is_deeply([qw(e@example.com e@example.org)],
+ [PublicInbox::Address::emails('User <e@example.com>, e@example.org')],
+ 'address extraction works as expected');
+
+is_deeply([PublicInbox::Address::emails('"ex@example.com" <ex@example.com>')],
+ [qw(ex@example.com)]);
+
+my @names = PublicInbox::Address::names(
+ 'User <e@e>, e@e, "John A. Doe" <j@d>, <x@x>');
+is_deeply(['User', 'e', 'John A. Doe', 'x'], \@names,
+ 'name extraction works as expected');
+
+
+done_testing;
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] www: show To/Cc destinations in conversation view
@ 2016-06-25 9:44 6% Eric Wong
2016-06-25 9:44 7% ` [PATCH 1/2] address: beef up the module with name list extaction Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-06-25 9:44 UTC (permalink / raw)
To: meta
And improve our name/address extraction to do it.
Eric Wong (2):
address: beef up the module with name list extaction
view: show To/Cc destinations in conversation view
MANIFEST | 1 +
lib/PublicInbox/Address.pm | 13 ++++++++++++-
lib/PublicInbox/View.pm | 18 +++++++++++++++---
t/address.t | 21 +++++++++++++++++++++
4 files changed, 49 insertions(+), 4 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-25 9:44 6% [PATCH 0/2] www: show To/Cc destinations in conversation view Eric Wong
2016-06-25 9:44 7% ` [PATCH 1/2] address: beef up the module with name list extaction Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).