* RE: issue with emails sent by bugzilla
@ 2019-04-23 12:39 0% ` Ali Alnubani
1 sibling, 0 replies; 3+ results
From: Ali Alnubani @ 2019-04-23 12:39 UTC (permalink / raw)
To: Eric Wong; +Cc: meta@public-inbox.org
Hi Eric,
I apologize again for my late response, I never got your replies (my
mail server must have quarantined them for some reason).
Ali Alnubani <alialnu@mellanox.com> wrote:
>>> Hi,
>>>
>>> I'm having an issue where all emails that are sent by Bugzilla aren't found by the http daemon, and
>>> instead, I will get:
>>> "
>>> Message-ID <for@bar>
>>> not found
>>>
>>> 1 partial match found:
>>> http://domain/list/foo@bar// (Which also redirects to the same page).
>>> ...
>>> ...
>>> "
>>>
>>> I'm guessing that this happens because Bugzilla uses the Message-Id format "<foo@bar/>" (notice the '/').
>>>
Eric Wong <e@80x24.org> wrote:
>> Might be a bug...(see below) I can check in a bit.
>>
>> Does: http://domain/list/foo@bar%2F/ work?
> Just tested, both of the following work without modifications:
>
> https://public-inbox.org/test/aaffffffadkljfadsfasdfasdfasdfffffffas@oops%2F/
> https://public-inbox.org/test/oops@test%2F/
>
> Are you running a recent-ish revision off git?
>
> I fixed some bugs at commit 4cf7804c2b263e4a92447315f534f76416d4ffad
> ("additional tests for bad Message-IDs in URLs") back last June
> thanks to Leah's bug report.
>
>
> Is your instance publically accessible?
I just checked and turns out this was an issue my nginx configurations.
I use nginx to proxy_pass requests to public-inbox-httpd, and the urls must
have been passed incorrectly.
Sorry about the formatting of the email, and thank you for your help :)
Thanks,
Ali
^ permalink raw reply [relevance 0%]
* Re: issue with emails sent by bugzilla
@ 2019-03-21 17:29 5% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2019-03-21 17:29 UTC (permalink / raw)
To: Ali Alnubani; +Cc: meta
Eric Wong <e@80x24.org> wrote:
> Might be a bug...(see below) I can check in a bit.
>
> Does: http://domain/list/foo@bar%2F/ work?
Just tested, both of the following work without modifications:
https://public-inbox.org/test/aaffffffadkljfadsfasdfasdfasdfffffffas@oops%2F/
https://public-inbox.org/test/oops@test%2F/
Are you running a recent-ish revision off git?
I fixed some bugs at commit 4cf7804c2b263e4a92447315f534f76416d4ffad
("additional tests for bad Message-IDs in URLs") back last June
thanks to Leah's bug report.
Is your instance publically accessible?
^ permalink raw reply [relevance 5%]
* [PATCH] additional tests for bad Message-IDs in URLs
@ 2018-06-26 7:46 7% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2018-06-26 7:46 UTC (permalink / raw)
To: Leah Neukirchen; +Cc: meta
Followup-to: 73cfed86d8a8287a
("www: use undecoded paths for Message-ID extraction")
Reported-by: Leah Neukirchen <leah@vuxu.org>
https://public-inbox.org/meta/8736xsb5s5.fsf@vuxu.org/
---
Oops, forgot this earlier :x
MANIFEST | 1 +
t/psgi_bad_mids.t | 85 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 86 insertions(+)
create mode 100644 t/psgi_bad_mids.t
diff --git a/MANIFEST b/MANIFEST
index 08a8ef4..68c79c9 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -182,6 +182,7 @@ t/perf-threading.t
t/plack.t
t/precheck.t
t/psgi_attach.t
+t/psgi_bad_mids.t
t/psgi_mount.t
t/psgi_search.t
t/psgi_text.t
diff --git a/t/psgi_bad_mids.t b/t/psgi_bad_mids.t
new file mode 100644
index 0000000..5008f5b
--- /dev/null
+++ b/t/psgi_bad_mids.t
@@ -0,0 +1,85 @@
+# Copyright (C) 2018 all contributors <meta@public-inbox.org>
+# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use strict;
+use warnings;
+use Test::More;
+use File::Temp qw/tempdir/;
+use PublicInbox::MIME;
+use PublicInbox::Config;
+use PublicInbox::WWW;
+my @mods = qw(DBD::SQLite Search::Xapian HTTP::Request::Common Plack::Test
+ URI::Escape Plack::Builder);
+foreach my $mod (@mods) {
+ eval "require $mod";
+ plan skip_all => "$mod missing for psgi_bad_mids.t" if $@;
+}
+use_ok($_) for @mods;
+use_ok 'PublicInbox::V2Writable';
+my $mainrepo = tempdir('pi-bad-mids-XXXXXX', TMPDIR => 1, CLEANUP => 1);
+my $cfgpfx = "publicinbox.bad-mids";
+my $ibx = {
+ mainrepo => $mainrepo,
+ name => 'bad-mids',
+ version => 2,
+ -primary_address => 'test@example.com',
+};
+$ibx = PublicInbox::Inbox->new($ibx);
+my $im = PublicInbox::V2Writable->new($ibx, 1);
+$im->{parallel} = 0;
+
+my $msgs = <<'';
+F1V5OR6NMF.3M649JTLO9IXD@tux.localdomain/hehe1"'<foo
+F1V5NB0PTU.3U0DCVGAJ750Z@tux.localdomain"'<>/foo
+F1V5MIHGCU.2ABINKW6WBE8N@tux.localdomain/raw
+F1V5LF9D9C.2QT5PGXZQ050E@tux.localdomain/t.atom
+F1V58X3CMU.2DCCVAKQZGADV@tux.localdomain/../../../../foo
+F1TVKINT3G.2S6I36MXMHYG6@tux.localdomain" onclick="alert(1)"
+
+my @mids = split(/\n/, $msgs);
+my $i = 0;
+foreach my $mid (@mids) {
+ my $data = << "";
+Subject: test
+Message-ID: <$mid>
+From: a\@example.com
+To: b\@example.com
+Date: Fri, 02 Oct 1993 00:00:0$i +0000
+
+
+ my $mime = PublicInbox::MIME->new(\$data);
+ ok($im->add($mime), "added $mid");
+ $i++
+}
+$im->done;
+
+my $cfg = {
+ "$cfgpfx.address" => $ibx->{-primary_address},
+ "$cfgpfx.mainrepo" => $mainrepo,
+};
+my $config = PublicInbox::Config->new($cfg);
+my $www = PublicInbox::WWW->new($config);
+test_psgi(sub { $www->call(@_) }, sub {
+ my ($cb) = @_;
+ my $res = $cb->(GET('/bad-mids/'));
+ is($res->code, 200, 'got 200 OK listing');
+ my $raw = $res->content;
+ foreach my $mid (@mids) {
+ ok(index($raw, $mid) < 0, "escaped $mid");
+ }
+
+ my (@xmids) = ($raw =~ m!\bhref="([^"]+)/t\.mbox\.gz"!sg);
+ is(scalar(@xmids), scalar(@mids),
+ 'got escaped links to all messages');
+
+ @xmids = reverse @xmids;
+ foreach my $i (0..$#xmids) {
+ $res = $cb->(GET("/bad-mids/$xmids[$i]/raw"));
+ is($res->code, 200, 'got 200 OK raw message');
+ like($res->content, qr/Message-ID: <\Q$mids[$i]\E>/s,
+ 'retrieved correct message');
+ }
+});
+
+done_testing();
+
+1;
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2018-06-09 17:06 Some points on public-inbox Leah Neukirchen
2018-06-12 10:09 ` Eric Wong
2018-06-12 11:31 ` Leah Neukirchen
2018-06-13 21:40 ` Eric Wong
2018-06-13 22:43 ` [PATCH] www: use undecoded paths for Message-ID extraction Eric Wong
2018-06-26 7:46 7% ` [PATCH] additional tests for bad Message-IDs in URLs Eric Wong
2019-03-21 13:45 issue with emails sent by bugzilla Ali Alnubani
2019-03-21 16:13 ` Eric Wong
2019-03-21 17:29 5% ` Eric Wong
2019-04-23 12:39 0% ` Ali Alnubani
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).