* Re: [PATCH] Makefile.PL: do not depend on git
2018-06-13 21:04 8% ` Eric Wong
@ 2018-06-13 21:20 8% ` Leah Neukirchen
0 siblings, 0 replies; 4+ results
From: Leah Neukirchen @ 2018-06-13 21:20 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
Eric Wong <e@80x24.org> writes:
> Leah Neukirchen <leah@vuxu.org> wrote:
>> Eric Wong <e@80x24.org> writes:
>>
>> > Subject: [PATCH] Makefile.PL: do not depend on git
>> >
>> > Otherwise, things do not work from a tarball distribution.
>>
>> The same issue also applies to ssoma.
>
> Thanks, pushed an identical change to
> 29b74d2c4cda7e06524ec92d5bc517cc07a05979 to ssoma.git
>
> That said, I'm not sure if it's worth continuing work on ssoma...
> I think focusing on existing standards such as NNTP is a better
> use of our time.
I wrote a prototype of a NNTP fetcher for mblaze:
http://git.vuxu.org/mblaze/tree/contrib/msuck
--
Leah Neukirchen <leah@vuxu.org> http://leah.zone
^ permalink raw reply [relevance 8%]
* Re: [PATCH] Makefile.PL: do not depend on git
2018-06-13 14:26 8% ` Leah Neukirchen
@ 2018-06-13 21:04 8% ` Eric Wong
2018-06-13 21:20 8% ` Leah Neukirchen
0 siblings, 1 reply; 4+ results
From: Eric Wong @ 2018-06-13 21:04 UTC (permalink / raw)
To: Leah Neukirchen; +Cc: meta
Leah Neukirchen <leah@vuxu.org> wrote:
> Eric Wong <e@80x24.org> writes:
>
> > Subject: [PATCH] Makefile.PL: do not depend on git
> >
> > Otherwise, things do not work from a tarball distribution.
>
> The same issue also applies to ssoma.
Thanks, pushed an identical change to
29b74d2c4cda7e06524ec92d5bc517cc07a05979 to ssoma.git
That said, I'm not sure if it's worth continuing work on ssoma...
I think focusing on existing standards such as NNTP is a better
use of our time.
^ permalink raw reply [relevance 8%]
* Re: [PATCH] Makefile.PL: do not depend on git
2018-06-13 2:07 14% ` [PATCH] Makefile.PL: do not depend on git Eric Wong
@ 2018-06-13 14:26 8% ` Leah Neukirchen
2018-06-13 21:04 8% ` Eric Wong
0 siblings, 1 reply; 4+ results
From: Leah Neukirchen @ 2018-06-13 14:26 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
Eric Wong <e@80x24.org> writes:
> Subject: [PATCH] Makefile.PL: do not depend on git
>
> Otherwise, things do not work from a tarball distribution.
The same issue also applies to ssoma.
--
Leah Neukirchen <leah@vuxu.org> http://leah.zone
^ permalink raw reply [relevance 8%]
* [PATCH] Makefile.PL: do not depend on git
@ 2018-06-13 2:07 14% ` Eric Wong
2018-06-13 14:26 8% ` Leah Neukirchen
0 siblings, 1 reply; 4+ results
From: Eric Wong @ 2018-06-13 2:07 UTC (permalink / raw)
To: Leah Neukirchen; +Cc: meta
Leah Neukirchen <leah@vuxu.org> wrote:
> Eric Wong <e@80x24.org> writes:
> > been trying to avoid being at the computer too much for health
> > reasons.
>
> No problem, get well soon.
Thanks, but they're more preventative measures than anything.
> >> 1) Makefile.PL only works properly when run from a checkout, not a tarball.
> >> I replaced the beginning with
> >>
> >> my @EXE_FILES = split("\n", `printf '%s\n' script/* 2>/dev/null`);
> >> my $PM_FILES = `find lib 2>/dev/null`;
> >
> > Thanks, I'd probably add "-name '*.pm'" to find(1) to filter out
> > directories. But I wonder if it's better to grep the MANIFEST
> > file...
>
> Yes, using MANIFEST is a better solution.
OK, will push this out:
---------8<-------
Subject: [PATCH] Makefile.PL: do not depend on git
Otherwise, things do not work from a tarball distribution.
Reported-by: Leah Neukirchen <leah@vuxu.org>
https://public-inbox.org/meta/871sdfzy80.fsf@gmail.com/
---
Makefile.PL | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Makefile.PL b/Makefile.PL
index a47e17b..027c3e6 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -3,9 +3,10 @@
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
use strict;
use ExtUtils::MakeMaker;
-my @EXE_FILES = split("\n", `git ls-files 'script/*' 2>/dev/null`);
-my $PM_FILES = `git ls-files lib '*.pm' 2>/dev/null`;
-$PM_FILES =~ tr/\n/ /;
+open my $m, '<', 'MANIFEST' or die "open(MANIFEST): $!\n";
+chomp(my @manifest = (<$m>));
+my @EXE_FILES = grep(m!^script/!, @manifest);
+my $PM_FILES = join(' ', grep(m!^lib/.*\.pm$!, @manifest));
WriteMakefile(
NAME => 'PublicInbox',
--
EW
^ permalink raw reply related [relevance 14%]
Results 1-4 of 4 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2018-06-09 17:06 Some points on public-inbox Leah Neukirchen
2018-06-12 10:09 ` Eric Wong
2018-06-12 11:31 ` Leah Neukirchen
2018-06-13 2:07 14% ` [PATCH] Makefile.PL: do not depend on git Eric Wong
2018-06-13 14:26 8% ` Leah Neukirchen
2018-06-13 21:04 8% ` Eric Wong
2018-06-13 21:20 8% ` Leah Neukirchen
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).