* [PATCH 0/2] www: memory reductions for multipart
@ 2020-01-11 6:28 6% Eric Wong
2020-01-11 6:28 7% ` [PATCH 1/2] xt/mem-msgview.t: change to test one multipart message Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-11 6:28 UTC (permalink / raw)
To: meta
Multipart messages in Email::MIME still cost us a lot of memory,
but this makes things less bad (not "good", just "less bad" :P)
Eric Wong (2):
xt/mem-msgview.t: change to test one multipart message
www: discard multipart parent on iteration
lib/PublicInbox/MsgIter.pm | 5 +++--
lib/PublicInbox/SolverGit.pm | 5 ++---
lib/PublicInbox/View.pm | 6 +++---
lib/PublicInbox/WwwAtomStream.pm | 4 ++--
lib/PublicInbox/WwwAttach.pm | 2 +-
xt/mem-msgview.t | 32 ++++++++++++++++++++++----------
6 files changed, 33 insertions(+), 21 deletions(-)
^ permalink raw reply [relevance 6%]
* [PATCH 1/2] xt/mem-msgview.t: change to test one multipart message
2020-01-11 6:28 6% [PATCH 0/2] www: memory reductions for multipart Eric Wong
@ 2020-01-11 6:28 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-11 6:28 UTC (permalink / raw)
To: meta
A single multipart message is far more common than
a reused Message-ID, so rewrite the test to only have
a single multipart message. Memory improvements will
be implemented in the next commit.
---
xt/mem-msgview.t | 32 ++++++++++++++++++++++----------
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/xt/mem-msgview.t b/xt/mem-msgview.t
index 1ea0f559..68b5919f 100644
--- a/xt/mem-msgview.t
+++ b/xt/mem-msgview.t
@@ -1,6 +1,8 @@
#!perl -w
# Copyright (C) 2020 all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+# Note: this may be altered as-needed to demonstrate improvements.
+# See history in git for this file.
use strict;
use IO::Handle; # ->flush
use Fcntl qw(SEEK_SET);
@@ -11,7 +13,7 @@ use Test::More;
my @mods = qw(DBD::SQLite BSD::Resource);
require_mods(@mods);
use_ok($_) for @mods;
-my $lines = $ENV{NR_LINES} // 100000;
+my $lines = $ENV{NR_LINES} // 50000;
my ($tmpdir, $for_destroy) = tmpdir();
my $inboxname = 'big';
my $inboxdir = "$tmpdir/big";
@@ -32,29 +34,39 @@ EOF
'inbox initialized');
$fh = tmpfile('big.eml', undef, my $append = 1) or die;
- printf($fh <<'EOF', $addr, $mid) or die;
+ my $hdr = sprintf(<<'EOF', $addr, $mid);
From: Dr. X <x@example.com>
To: Nikki <%s>
Date: Tue, 3 May 1988 00:00:00 +0000
Subject: todo
Message-ID: <%s>
+MIME-Version: 1.0
+Content-Type: multipart/mixed; boundary="FOO"
+Content-Disposition: inline
+
+--FOO
+Content-Type: text/plain; charset=utf-8
+Content-Disposition: inline
+
+EOF
+ print $fh $hdr or die;
+ for (0..$lines) { print $fh 'x' x 72, "\n" or die }
+ print $fh <<EOF or die;
+
+--FOO
+Content-Type: text/plain; charset=utf-8
+Content-Disposition: inline
EOF
for (0..$lines) { print $fh 'x' x 72, "\n" or die }
+ print $fh "\n--FOO--\n" or die;
$fh->flush or die;
sysseek($fh, 0, SEEK_SET) or die;
my $env = { ORIGINAL_RECIPIENT => $addr };
my $err = '';
my $opt = { 0 => $fh, 2 => \$err, run_mode => 0 };
ok(run_script([qw(-mda --no-precheck)], $env, $opt),
- '1st message delivered');
-
- # resend the message with same mid but different content
- print $fh "mindcrime\n" or die;
- $fh->flush or die;
- sysseek($fh, 0, SEEK_SET) or die;
- ok(run_script([qw(-mda --no-precheck)], $env, $opt),
- '2nd message delivered');
+ 'message delivered');
}
my $www = PublicInbox::WWW->new;
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-11 6:28 6% [PATCH 0/2] www: memory reductions for multipart Eric Wong
2020-01-11 6:28 7% ` [PATCH 1/2] xt/mem-msgview.t: change to test one multipart message Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).