* [PATCH 1/6] xapcmd: simplify sub reference
2020-08-12 9:17 6% [PATCH 0/6] xcpdb -index improvements Eric Wong
@ 2020-08-12 9:17 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-08-12 9:17 UTC (permalink / raw)
To: meta
We don't need to fully-qualify when referring to subs in
the same namespace, nor do we need make a SCALAR ref only
to dereference it
(Yes, still learning Perl :x)
---
lib/PublicInbox/Xapcmd.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Xapcmd.pm b/lib/PublicInbox/Xapcmd.pm
index 348621cef..6fcc9e90c 100644
--- a/lib/PublicInbox/Xapcmd.pm
+++ b/lib/PublicInbox/Xapcmd.pm
@@ -253,7 +253,7 @@ sub _run {
sub run {
my ($ibx, $task, $opt) = @_; # task = 'cpdb' or 'compact'
- my $cb = \&${\"PublicInbox::Xapcmd::$task"};
+ my $cb = \&$task;
PublicInbox::Admin::progress_prepare($opt ||= {});
defined(my $dir = $ibx->{inboxdir}) or die "no inboxdir defined\n";
-d $dir or die "inboxdir=$dir does not exist\n";
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] xcpdb -index improvements
@ 2020-08-12 9:17 6% Eric Wong
2020-08-12 9:17 7% ` [PATCH 1/6] xapcmd: simplify sub reference Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-08-12 9:17 UTC (permalink / raw)
To: meta
Nothing terribly exciting, since xcpdb isn't really used often.
But it'd be bad if it flooded the system with many parallel
processes on HDD because -index was configured for many small
shards. So now it now supports --sequential-shard and all the
other index options.
Eric Wong (6):
xapcmd: simplify sub reference
xcpdb: support --no-fsync from CLI
xapcmd: reduce CPU idling when shards exceeds job count
admin: don't warn when --jobs exceeds shards
xcpdb: wire up new index options and --help
v2writable: remove IdxStack import
Documentation/public-inbox-xcpdb.pod | 19 +++++++-
lib/PublicInbox/Admin.pm | 4 +-
lib/PublicInbox/V2Writable.pm | 1 -
lib/PublicInbox/Xapcmd.pm | 12 +++--
script/public-inbox-xcpdb | 65 +++++++++++++++++++++++-----
5 files changed, 83 insertions(+), 18 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-08-12 9:17 6% [PATCH 0/6] xcpdb -index improvements Eric Wong
2020-08-12 9:17 7% ` [PATCH 1/6] xapcmd: simplify sub reference Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).