* [PATCH 2/4] xap_helper.h: fix non-assignable stderr case
2023-12-01 2:07 6% [PATCH 0/4] DragonFly-related fixes Eric Wong
@ 2023-12-01 2:07 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-12-01 2:07 UTC (permalink / raw)
To: meta
I mixed up "flush" with "close" :x
Fixes: 87b7f633f241 (xap_helper: implement mset endpoint for WWW, IMAP, etc...)
---
lib/PublicInbox/xap_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/xap_helper.h b/lib/PublicInbox/xap_helper.h
index 18665567..c1ab66f3 100644
--- a/lib/PublicInbox/xap_helper.h
+++ b/lib/PublicInbox/xap_helper.h
@@ -714,7 +714,7 @@ static void stderr_restore(FILE *tmp_err)
stderr = orig_err;
return;
#endif
- ERR_CLOSE(stderr, EXIT_FAILURE);
+ ERR_FLUSH(stderr);
while (dup2(orig_err_fd, STDERR_FILENO) < 0) {
if (errno != EINTR)
err(EXIT_FAILURE, "dup2(%d => 2)", orig_err_fd);
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] DragonFly-related fixes
@ 2023-12-01 2:07 6% Eric Wong
2023-12-01 2:07 7% ` [PATCH 2/4] xap_helper.h: fix non-assignable stderr case Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-12-01 2:07 UTC (permalink / raw)
To: meta
2/4 probably affects NetBSD and OpenBSD, too, but tests don't
always fail...
Eric Wong (4):
t/xap_helper: make sendmsg errors more obvious
xap_helper.h: fix non-assignable stderr case
tests: note kevent+tmpfs failures on DragonFly <= 6.4
xap_helper: enable stderr assignment on DragonFly
lib/PublicInbox/TestCommon.pm | 23 ++++++++++++++++++++++-
lib/PublicInbox/xap_helper.h | 4 ++--
t/dir_idle.t | 7 +++++--
t/kqnotify.t | 2 +-
t/xap_helper.t | 1 +
5 files changed, 31 insertions(+), 6 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-12-01 2:07 6% [PATCH 0/4] DragonFly-related fixes Eric Wong
2023-12-01 2:07 7% ` [PATCH 2/4] xap_helper.h: fix non-assignable stderr case Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).