* [PATCH 4/4] xap_helper: fix fcntl() argument order
2023-09-07 0:54 6% [PATCH 0/4] another round of portability fixes Eric Wong
@ 2023-09-07 0:54 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-09-07 0:54 UTC (permalink / raw)
To: meta
*sigh* I only noticed this when running `make check-run' under
OpenBSD.
---
lib/PublicInbox/xap_helper.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/xap_helper.h b/lib/PublicInbox/xap_helper.h
index 73590efd..70760367 100644
--- a/lib/PublicInbox/xap_helper.h
+++ b/lib/PublicInbox/xap_helper.h
@@ -1168,9 +1168,9 @@ int main(int argc, char *argv[])
if (!worker_pids) err(EXIT_FAILURE, "calloc");
if (pipe(pipefds)) err(EXIT_FAILURE, "pipe");
- int fl = fcntl(F_GETFL, pipefds[1]);
+ int fl = fcntl(pipefds[1], F_GETFL);
if (fl == -1) err(EXIT_FAILURE, "F_GETFL");
- if (fcntl(F_SETFL, pipefds[1], fl | O_NONBLOCK))
+ if (fcntl(pipefds[1], F_SETFL, fl | O_NONBLOCK))
err(EXIT_FAILURE, "F_SETFL");
CHECK(int, 0, sigdelset(&pset, SIGCHLD));
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] another round of portability fixes
@ 2023-09-07 0:54 6% Eric Wong
2023-09-07 0:54 7% ` [PATCH 4/4] xap_helper: fix fcntl() argument order Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-09-07 0:54 UTC (permalink / raw)
To: meta
Most notably, some of these problems fixed on NetBSD and
OpenBSD are problems on Linux and FreeBSD, too.
1/4 likely affects other platforms, but was only noticed on NetBSD.
4/4 is an important fix which applies to all platforms,
but I only noticed it on OpenBSD.
Eric Wong (4):
tail_notify: reinstate watch on reopen
t/cmd_ipc.t: allow EMSGSIZE send error for NetBSD
t/search.t: tweak dir group semantics for all *BSDs
xap_helper: fix fcntl() argument order
lib/PublicInbox/TailNotify.pm | 1 +
lib/PublicInbox/xap_helper.h | 4 ++--
t/cmd_ipc.t | 9 +++++----
t/search.t | 5 +++--
4 files changed, 11 insertions(+), 8 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-09-07 0:54 6% [PATCH 0/4] another round of portability fixes Eric Wong
2023-09-07 0:54 7% ` [PATCH 4/4] xap_helper: fix fcntl() argument order Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).