* [PATCH 2/2] www_stream: description header links to top $INBOX_URL
2021-08-28 11:50 5% ` [PATCH 0/2] www: split out mirror to /text/ Eric Wong
@ 2021-08-28 11:50 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-08-28 11:50 UTC (permalink / raw)
To: meta
Making the inbox description link back to the most recent
per-inbox topics from text/ and $OID/s/ URLs seems useful,
rather than keeping the description up there.
Followup-to: 6c853f5256f3a324 ("www: improve navigation around contemporary threads")
---
lib/PublicInbox/WwwStream.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index c960edc5..472316c2 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -49,6 +49,8 @@ sub html_top ($) {
# we had some kind of query, link to /$INBOX/?t=YYYYMMDDhhmmss
} elsif ($ctx->{qp}->{t}) {
$top = qq(<a\nhref="./">$top</a>);
+ } elsif (length($upfx)) {
+ $top = qq(<a\nhref="$upfx">$top</a>);
}
my $code = $ibx->{coderepo} ? qq( / <a\nhref=#code>code</a>) : '';
# id=mirror must exist for legacy bookmarks
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] www: split out mirror to /text/
@ 2021-08-28 11:50 5% ` Eric Wong
2021-08-28 11:50 7% ` [PATCH 2/2] www_stream: description header links to top $INBOX_URL Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-08-28 11:50 UTC (permalink / raw)
To: meta; +Cc: Konstantin Ryabitsev
Maybe this works better? *shrug*
I was somewhat under the impression every page needed to
link/advertise code under the AGPL, but maybe just one HTML page
is fine... We can't advertise our AGPL code to NNTP/IMAP users,
nor to people using Atom feed readers.
So maybe just burying the code link in the "mirror" link is
fine. I could never be comfortable with promoting anything I
do, anyways.
Eric Wong (2):
www: move mirror instructions to /text/
www_stream: description header links to top $INBOX_URL
lib/PublicInbox/WwwListing.pm | 4 +-
lib/PublicInbox/WwwStream.pm | 118 +++---------------------------
lib/PublicInbox/WwwText.pm | 134 +++++++++++++++++++++++++++++++++-
t/psgi_mount.t | 11 +--
4 files changed, 145 insertions(+), 122 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-08-26 13:27 [PATCH 0/8] various WWW + extindex stuff Konstantin Ryabitsev
2021-08-28 11:50 5% ` [PATCH 0/2] www: split out mirror to /text/ Eric Wong
2021-08-28 11:50 7% ` [PATCH 2/2] www_stream: description header links to top $INBOX_URL Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).