* [PATCH 0/2] www: footer tweaks
@ 2016-07-21 2:02 4% Eric Wong
2016-07-21 2:02 7% ` [PATCH 1/2] www: a note .onion URLs require the usage of Tor Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-07-21 2:02 UTC (permalink / raw)
To: meta
Usability is hard and requires much pondering for improvements
which are hard-to-measure :<
Eric Wong (2):
www: a note .onion URLs require the usage of Tor
www: redefinable project name and URL
lib/PublicInbox/WwwStream.pm | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
^ permalink raw reply [relevance 4%]
* [PATCH 1/2] www: a note .onion URLs require the usage of Tor
2016-07-21 2:02 4% [PATCH 0/2] www: footer tweaks Eric Wong
@ 2016-07-21 2:02 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-07-21 2:02 UTC (permalink / raw)
To: meta
Not everybody knows what .onion URLs are, so refer them to Tor.
---
lib/PublicInbox/WwwStream.pm | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index bdc8048..de457b4 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -8,6 +8,7 @@ use warnings;
use PublicInbox::Hval qw(ascii_html);
use URI;
use constant PI_URL => 'https://public-inbox.org/';
+our $TOR_URL = 'https://www.torproject.org/';
sub close {}
@@ -68,8 +69,10 @@ sub _html_end {
chop $http;
my %seen = ( $http => 1 );
my @urls = ($http);
+ my $need_tor;
foreach my $u (@{$obj->cloneurl}) {
next if $seen{$u};
+ $need_tor = 1 if $u =~ m!\A[^:]+://\w+\.onion/!;
$seen{$u} = 1;
push @urls, $u =~ /\Ahttps?:/ ? qq(<a\nhref="$u">$u</a>) : $u;
}
@@ -79,12 +82,17 @@ sub _html_end {
$urls .= "\n" .
join("\n", map { "\tgit clone --mirror $_" } @urls);
}
+
+ if ($need_tor) {
+ $urls .= "\n note: .onion URLs require Tor: ";
+ $urls .= qq[<a\nhref="$TOR_URL">$TOR_URL</a>];
+ }
my $url = PublicInbox::Hval::prurl($ctx->{env}, PI_URL);
- '<hr><pre>'.join("\n",
- '- ' . $desc,
+ '<hr><pre>'.join("\n\n",
+ $desc,
$urls,
'Served with public-inbox: '.
- qq(git clone <a\nhref="$url">$url</a> public-inbox),
+ qq(git clone <a\nhref="$url">$url</a> public-inbox)
).'</pre></body></html>';
}
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-07-21 2:02 4% [PATCH 0/2] www: footer tweaks Eric Wong
2016-07-21 2:02 7% ` [PATCH 1/2] www: a note .onion URLs require the usage of Tor Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).