* [PATCH 00/11] watch: fix contention w/ Maildir & NNTP
@ 2020-08-31 4:41 6% Eric Wong
2020-08-31 4:41 7% ` [PATCH 02/11] watchmaildir: use v5.10.1, drop warnings Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-08-31 4:41 UTC (permalink / raw)
To: meta
Here's a bunch of fixes to improve watch performance when
both Maildirs and NNTP are being watched (possibly on the same
inbox, or if `watchspam' is configured for spam removals).
Wakeups are reduced, and inbox.lock contention is minimized by
using read-only ->over to check for `watchspam' removals.
These affect IMAP, too; but I've been mainly using NNTP.
Eric Wong (11):
watch: limit batch size of NNTP and IMAP workers, too
watchmaildir: use v5.10.1, drop warnings
rename WatchMaildir => Watch
watch: log signal activities to STDERR
watch: avoid unnecessary spawning on spam removals
watch: block signals before fork on non-signalfd/kevent systems
watch: comments and tiny cleanups
ds: avoid excessive queueing when reaping PIDs
watch: use EOFpipe to reduce dwaitpid wakeups
ds: avoid unnecessary timer for waitpid
replace ParentPipe with EOFpipe
MANIFEST | 4 +-
lib/PublicInbox/DS.pm | 38 +++---
lib/PublicInbox/Daemon.pm | 6 +-
lib/PublicInbox/EOFpipe.pm | 24 ++++
lib/PublicInbox/Import.pm | 3 +
lib/PublicInbox/ParentPipe.pm | 23 ----
lib/PublicInbox/V2Writable.pm | 3 +
lib/PublicInbox/{WatchMaildir.pm => Watch.pm} | 111 +++++++++++++-----
script/public-inbox-watch | 34 ++++--
t/imapd.t | 2 +-
t/nntpd.t | 2 +-
t/watch_filter_rubylang.t | 4 +-
t/watch_imap.t | 4 +-
t/watch_maildir.t | 18 +--
t/watch_maildir_v2.t | 22 ++--
t/watch_multiple_headers.t | 4 +-
t/watch_nntp.t | 4 +-
17 files changed, 190 insertions(+), 116 deletions(-)
create mode 100644 lib/PublicInbox/EOFpipe.pm
delete mode 100644 lib/PublicInbox/ParentPipe.pm
rename lib/PublicInbox/{WatchMaildir.pm => Watch.pm} (92%)
^ permalink raw reply [relevance 6%]
* [PATCH 02/11] watchmaildir: use v5.10.1, drop warnings
2020-08-31 4:41 6% [PATCH 00/11] watch: fix contention w/ Maildir & NNTP Eric Wong
@ 2020-08-31 4:41 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-08-31 4:41 UTC (permalink / raw)
To: meta; +Cc: Eric Wong
From: Eric Wong <e@yhbt.net>
Declare 5.10.1 to avoid potential compatibility problems with
Perl 7/8 down the line. We'll rely on the command-line to set
or drop warnings during development, at least.
---
lib/PublicInbox/WatchMaildir.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm
index 5176ef69..1c7ac6c0 100644
--- a/lib/PublicInbox/WatchMaildir.pm
+++ b/lib/PublicInbox/WatchMaildir.pm
@@ -5,7 +5,7 @@
# http://wiki2.dovecot.org/MailboxFormat/Maildir
package PublicInbox::WatchMaildir;
use strict;
-use warnings;
+use v5.10.1;
use PublicInbox::Eml;
use PublicInbox::InboxWritable qw(eml_from_path warn_ignore_cb);
use PublicInbox::Filter::Base qw(REJECT);
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-08-31 4:41 6% [PATCH 00/11] watch: fix contention w/ Maildir & NNTP Eric Wong
2020-08-31 4:41 7% ` [PATCH 02/11] watchmaildir: use v5.10.1, drop warnings Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).