* [PATCH 1/3] viewvcs: avoid one ascii_html call
2022-10-10 21:34 5% [PATCH 0/3] www: viewvcs: tags + minor updates Eric Wong
@ 2022-10-10 21:34 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-10-10 21:34 UTC (permalink / raw)
To: meta
We can reuse its result for the button text.
---
lib/PublicInbox/ViewVCS.pm | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 72b79ab7..86bae7d6 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -247,9 +247,14 @@ EOM
my $rows = ($q =~ tr/\n/\n/) + 1;
$q = ascii_html($q);
my $ibx_url = ibx_url_for($ctx);
- my $alt = $ibx_url ? ' '.ascii_html($ibx_url) : '';
- $ibx_url = ascii_html($ibx_url) if defined $ibx_url;
- $ibx_url //= $upfx;
+ my $alt;
+ if (defined $ibx_url) {
+ $ibx_url = ascii_html($ibx_url);
+ $alt = ' '.$ibx_url;
+ } else {
+ $ibx_url = $upfx;
+ $alt = '';
+ }
print $zfh <<EOM;
<hr><form action="$ibx_url"
id=related><pre>find related emails, including ancestors/descendants/conflicts
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] www: viewvcs: tags + minor updates
@ 2022-10-10 21:34 5% Eric Wong
2022-10-10 21:34 7% ` [PATCH 1/3] viewvcs: avoid one ascii_html call Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-10-10 21:34 UTC (permalink / raw)
To: meta
I noticed the /$CODEREPO/ summary endpoint links to tags,
so we'll support handling annotated tags via /($CODEREPO|$INBOX)/$OID/s/,
now. Still not sure how to best deal with multiple search endpoints,
yet...
Eric Wong (3):
viewvcs: avoid one ascii_html call
xt/solver: skip on missing publicinbox.git.coderepo
www: viewvcs: display annotated tags as discreet objects
lib/PublicInbox/ViewVCS.pm | 51 +++++++++++++++++++++++++++++++++++---
xt/solver.t | 12 +++++++--
2 files changed, 57 insertions(+), 6 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-10-10 21:34 5% [PATCH 0/3] www: viewvcs: tags + minor updates Eric Wong
2022-10-10 21:34 7% ` [PATCH 1/3] viewvcs: avoid one ascii_html call Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).