* [PATCH] view: tighten up regexps used for trimming index
@ 2014-08-28 5:27 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2014-08-28 5:27 UTC (permalink / raw)
To: meta; +Cc: Eric Wong
The previous regexp matches were too aggressive w.r.t. scissors.
We destroy trailing whitespace anyways, so do not worry about it
when cutting signatures and patches off.
---
lib/PublicInbox/View.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 23cb369..d1bb935 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -95,11 +95,11 @@ sub index_entry {
$s =~ s/(?:^[^\n]*:\s*\n)?(?:^>[^\n]*\n)+(?:^\s*\n)?//mg;
# Drop signatures
- $s =~ s/\n*-- \n.*\z//s;
+ $s =~ s/^-- \n.*\z//ms;
# drop the remainder of git patches, they're usually better
# to review when the full message is viewed
- if ($s =~ s/\n*---\n.*\z//s) {
+ if ($s =~ s/^---\n.*\z//ms) {
$more = "$pfx...\n";
}
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-08-28 5:27 7% [PATCH] view: tighten up regexps used for trimming index Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).