* [PATCH 0/7] www: avoid recursion for thread walking
@ 2016-06-21 3:11 7% Eric Wong
2016-06-21 3:11 5% ` [PATCH 1/7] view: remove upfx parameter from thread skeleton dump Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-06-21 3:11 UTC (permalink / raw)
To: meta
Deep message threads can cause problems for perl since stack
seems to be much more expensive than arrays. Switch to a
non-recursive thread walking design and commonalize some
common idioms, too.
Eric Wong (7):
view: remove upfx parameter from thread skeleton dump
view: remove dst parameter from thread skeleton dump
view: remove recursion from thread skeleton dump
view: remove recursion from expanded thread view
searchview: remove recursion from thread view
view: avoid recursion in topic index
view: common thread walking interface
lib/PublicInbox/SearchView.pm | 9 ++------
lib/PublicInbox/View.pm | 53 +++++++++++++++++++++----------------------
2 files changed, 28 insertions(+), 34 deletions(-)
^ permalink raw reply [relevance 7%]
* [PATCH 1/7] view: remove upfx parameter from thread skeleton dump
2016-06-21 3:11 7% [PATCH 0/7] www: avoid recursion for thread walking Eric Wong
@ 2016-06-21 3:11 5% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-21 3:11 UTC (permalink / raw)
To: meta
This makes the string creation somewhat simpler hopefully
makes the code easier-to-reason with.
---
lib/PublicInbox/View.pm | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index dfae44f..9095c50 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -383,9 +383,10 @@ sub thread_skel {
cur => $mid,
prev_attr => '',
prev_level => 0,
+ upfx => "$tpfx../",
};
for (thread_results(load_results($sres))->rootset) {
- skel_dump($dst, $state, $tpfx, $_, 0);
+ skel_dump($dst, $state, $_, 0);
}
$ctx->{next_msg} = $state->{next_msg};
$ctx->{parent_msg} = $parent;
@@ -663,7 +664,7 @@ sub _msg_date {
sub fmt_ts { POSIX::strftime('%Y-%m-%d %k:%M', gmtime($_[0])) }
sub _skel_header {
- my ($dst, $state, $upfx, $hdr, $level) = @_;
+ my ($dst, $state, $hdr, $level) = @_;
my $cur = $state->{cur};
my $mid = mid_clean($hdr->header_raw('Message-ID'));
@@ -705,18 +706,18 @@ sub _skel_header {
$s = $s->as_html;
}
my $m = PublicInbox::Hval->new_msgid($mid);
- $m = $upfx . '../' . $m->as_href . '/';
+ $m = $state->{upfx} . $m->as_href . '/';
$$dst .= "$pfx<a\nhref=\"$m\">";
$$dst .= defined($s) ? "$s</a> $f\n" : "$f</a>\n";
}
sub skel_dump {
- my ($dst, $state, $upfx, $node, $level) = @_;
+ my ($dst, $state, $node, $level) = @_;
return unless $node;
if (my $mime = $node->message) {
my $hdr = $mime->header_obj;
my $mid = mid_clean($hdr->header_raw('Message-ID'));
- _skel_header($dst, $state, $upfx, $hdr, $level);
+ _skel_header($dst, $state, $hdr, $level);
} else {
my $mid = $node->messageid;
if ($mid eq 'subject dummy') {
@@ -725,13 +726,13 @@ sub skel_dump {
$$dst .= ' [not found] ';
$$dst .= indent_for($level) . th_pfx($level);
$mid = PublicInbox::Hval->new_msgid($mid);
- my $href = "$upfx../" . $mid->as_href . '/';
+ my $href = $state->{upfx} . $mid->as_href . '/';
my $html = $mid->as_html;
$$dst .= qq{<<a\nhref="$href">$html</a>>\n};
}
}
- skel_dump($dst, $state, $upfx, $node->child, $level+1);
- skel_dump($dst, $state, $upfx, $node->next, $level);
+ skel_dump($dst, $state, $node->child, $level+1);
+ skel_dump($dst, $state, $node->next, $level);
}
sub sort_ts {
^ permalink raw reply related [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-21 3:11 7% [PATCH 0/7] www: avoid recursion for thread walking Eric Wong
2016-06-21 3:11 5% ` [PATCH 1/7] view: remove upfx parameter from thread skeleton dump Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).