* [PATCH] view: fixup ghost message errors from threading tweaks
@ 2015-12-25 11:00 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2015-12-25 11:00 UTC (permalink / raw)
To: meta
Ghost message links didn't show up too well after
commit bc067a7562a586bed92401fe1084bbe423b9451a
("view: move thread info near top of single view")
Additionally, attribution lacked a space when subjects changed
mid-thread.
---
lib/PublicInbox/View.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 98d0219..523d27f 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -774,7 +774,7 @@ sub _inline_header {
my $m = PublicInbox::Hval->new_msgid($mid);
$m = $upfx . '../' . $m->as_href . '/';
if (defined $s) {
- $$dst .= "$pfx$dot<a\nhref=\"$m\">$s</a>$attr\n";
+ $$dst .= "$pfx$dot<a\nhref=\"$m\">$s</a> $attr\n";
} else {
$$dst .= "$pfx$dot<a\nhref=\"$m\">$f</a>\n";
}
@@ -791,7 +791,7 @@ sub inline_dump {
_inline_header($dst, $state, $upfx, $mime, $level);
} else {
my $dot = $level == 0 ? '' : '` ';
- my $pfx = length(' 1970-01-01 13:37 ') .
+ my $pfx = (' ' x length(' 1970-01-01 13:37 ')).
(INDENT x $level) . $dot;
$$dst .= $pfx;
$$dst .= ghost_parent("$upfx../", $node->messageid) . "\n";
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-12-25 10:31 [PATCH] view: move thread info near top of single view Eric Wong
2015-12-25 10:40 ` [PATCH v2] " Eric Wong
2015-12-25 11:00 7% ` [PATCH] view: fixup ghost message errors from threading tweaks Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).