* [PATCH 0/7] www: avoid recursion for thread walking
@ 2016-06-21 3:11 7% Eric Wong
2016-06-21 3:12 6% ` [PATCH 7/7] view: common thread walking interface Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-06-21 3:11 UTC (permalink / raw)
To: meta
Deep message threads can cause problems for perl since stack
seems to be much more expensive than arrays. Switch to a
non-recursive thread walking design and commonalize some
common idioms, too.
Eric Wong (7):
view: remove upfx parameter from thread skeleton dump
view: remove dst parameter from thread skeleton dump
view: remove recursion from thread skeleton dump
view: remove recursion from expanded thread view
searchview: remove recursion from thread view
view: avoid recursion in topic index
view: common thread walking interface
lib/PublicInbox/SearchView.pm | 9 ++------
lib/PublicInbox/View.pm | 53 +++++++++++++++++++++----------------------
2 files changed, 28 insertions(+), 34 deletions(-)
^ permalink raw reply [relevance 7%]
* [PATCH 7/7] view: common thread walking interface
2016-06-21 3:11 7% [PATCH 0/7] www: avoid recursion for thread walking Eric Wong
@ 2016-06-21 3:12 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-21 3:12 UTC (permalink / raw)
To: meta
Since we have a common pattern, for walking threads,
extract it into a function and reduce the amount of code
we haev.
This will make it easier to switch to an event-driven interface
for getline, too.
---
lib/PublicInbox/SearchView.pm | 8 +-------
lib/PublicInbox/View.pm | 35 ++++++++++++++---------------------
2 files changed, 15 insertions(+), 28 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index ba25827..ae875bf 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -172,13 +172,7 @@ sub tdump {
fh => $fh,
};
$ctx->{searchview} = 1;
- my @q = map { (0, $_) } $th->rootset;
- while (@q) {
- my $level = shift @q;
- my $node = shift @q or next;
- tdump_ent($state, $level, $node);
- unshift @q, $level+1, $node->child, $level, $node->next;
- }
+ PublicInbox::View::walk_thread($th, $state, *tdump_ent);
PublicInbox::View::thread_adj_level($state, 0);
$fh->write(search_nav_bot($mset, $q). "\n\n" .
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 8075e4a..b6fa2a3 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -152,6 +152,17 @@ sub thread_html {
sub { emit_thread_html($_[0], $ctx, $foot, $srch) }
}
+sub walk_thread {
+ my ($th, $state, $cb) = @_;
+ my @q = map { (0, $_) } $th->rootset;
+ while (@q) {
+ my $level = shift @q;
+ my $node = shift @q or next;
+ $cb->($state, $level, $node);
+ unshift @q, $level+1, $node->child, $level, $node->next;
+ }
+}
+
# only private functions below.
sub emit_thread_html {
@@ -177,13 +188,7 @@ sub emit_thread_html {
pre_anchor_entry($seen, $_) for (@$msgs);
__thread_entry($state, $_, 0) for (@$msgs);
} else {
- my @q = map { (0, $_) } thread_results($msgs)->rootset;
- while (@q) {
- my $level = shift @q;
- my $node = shift @q or next;
- thread_entry($state, $level, $node);
- unshift @q, $level+1, $node->child, $level, $node->next;
- }
+ walk_thread(thread_results($msgs), $state, *thread_entry);
if (my $max = $state->{cur_level}) {
$state->{fh}->write(
('</ul></li>' x ($max - 1)) . '</ul>');
@@ -391,13 +396,7 @@ sub thread_skel {
upfx => "$tpfx../",
dst => $dst,
};
- my @q = map { (0, $_) } thread_results(load_results($sres))->rootset;
- while (@q) {
- my $level = shift @q;
- my $node = shift @q or next;
- skel_dump($state, $level, $node);
- unshift @q, $level+1, $node->child, $level, $node->next;
- }
+ walk_thread(thread_results(load_results($sres)), $state, *skel_dump);
$ctx->{next_msg} = $state->{next_msg};
$ctx->{parent_msg} = $parent;
}
@@ -847,13 +846,7 @@ sub emit_index_topics {
my $sres = $state->{srch}->query('', \%opts);
my $nr = scalar @{$sres->{msgs}} or last;
$sres = load_results($sres);
- my @q = map { (0, $_) } thread_results($sres)->rootset;
- while (@q) {
- my $level = shift @q;
- my $node = shift @q or next;
- add_topic($state, $level, $node);
- unshift @q, $level+1, $node->child, $level, $node->next;
- }
+ walk_thread(thread_results($sres), $state, *add_topic);
$opts{offset} += $nr;
}
^ permalink raw reply related [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-21 3:11 7% [PATCH 0/7] www: avoid recursion for thread walking Eric Wong
2016-06-21 3:12 6% ` [PATCH 7/7] view: common thread walking interface Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).