* [PATCH] tests: remove some "git config" calls after "git init"
@ 2020-01-05 0:06 15% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-01-05 0:06 UTC (permalink / raw)
To: meta
Creating a hash and iterating through it just to run "git
config" is ugly and slow. Just write out the text file in a
human-friendly way since the git-config file format is stable
and won't break randomly.
---
t/cgi.t | 18 ++++++++----------
t/mda.t | 15 +++++++--------
t/plack.t | 20 +++++++++-----------
3 files changed, 24 insertions(+), 29 deletions(-)
diff --git a/t/cgi.t b/t/cgi.t
index 424b738e..90543a7a 100644
--- a/t/cgi.t
+++ b/t/cgi.t
@@ -13,7 +13,6 @@ my $pi_home = "$home/.public-inbox";
my $pi_config = "$pi_home/config";
my $maindir = "$tmpdir/main.git";
my $addr = 'test-public@example.com';
-my $cfgpfx = "publicinbox.test";
{
is(1, mkdir($home, 0755), "setup ~/ for testing");
@@ -23,15 +22,14 @@ my $cfgpfx = "publicinbox.test";
open my $fh, '>', "$maindir/description" or die "open: $!\n";
print $fh "test for public-inbox\n";
close $fh or die "close: $!\n";
- my %cfg = (
- "$cfgpfx.address" => $addr,
- "$cfgpfx.inboxdir" => $maindir,
- "$cfgpfx.indexlevel" => 'basic',
- );
- while (my ($k,$v) = each %cfg) {
- is(0, system(qw(git config --file), $pi_config, $k, $v),
- "setup $k");
- }
+ open $fh, '>>', $pi_config or die;
+ print $fh <<EOF or die;
+[publicinbox "test"]
+ address = $addr
+ inboxdir = $maindir
+ indexlevel = basic
+EOF
+ close $fh or die "close: $!\n";
}
use_ok 'PublicInbox::Git';
diff --git a/t/mda.t b/t/mda.t
index 4556e323..631bb861 100644
--- a/t/mda.t
+++ b/t/mda.t
@@ -49,14 +49,13 @@ my $fail_bad_header = sub ($$$) {
is(1, mkdir($pi_home, 0755), "setup ~/.public-inbox");
is(0, system(qw(git init -q --bare), $maindir), "git init (main)");
- my %cfg = (
- "$cfgpfx.address" => $addr,
- "$cfgpfx.inboxdir" => $maindir,
- );
- while (my ($k,$v) = each %cfg) {
- is(0, system(qw(git config --file), $pi_config, $k, $v),
- "setup $k");
- }
+ open my $fh, '>>', $pi_config or die;
+ print $fh <<EOF or die;
+[publicinbox "test"]
+ address = $addr
+ inboxdir = $maindir
+EOF
+ close $fh or die;
}
local $ENV{GIT_COMMITTER_NAME} = eval {
diff --git a/t/plack.t b/t/plack.t
index f0dc4bbb..ec45b02c 100644
--- a/t/plack.t
+++ b/t/plack.t
@@ -10,7 +10,6 @@ my ($tmpdir, $for_destroy) = tmpdir();
my $pi_config = "$tmpdir/config";
my $maindir = "$tmpdir/main.git";
my $addr = 'test-public@example.com';
-my $cfgpfx = "publicinbox.test";
my @mods = qw(HTTP::Request::Common Plack::Test URI::Escape);
require_mods(@mods);
use_ok 'PublicInbox::Import';
@@ -24,16 +23,15 @@ foreach my $mod (@mods) { use_ok $mod; }
open my $fh, '>', "$maindir/description" or die "open: $!\n";
print $fh "test for public-inbox\n";
close $fh or die "close: $!\n";
- my %cfg = (
- "$cfgpfx.address" => $addr,
- "$cfgpfx.inboxdir" => $maindir,
- "$cfgpfx.url" => 'http://example.com/test/',
- "$cfgpfx.newsgroup" => 'inbox.test',
- );
- while (my ($k,$v) = each %cfg) {
- is(0, system(qw(git config --file), $pi_config, $k, $v),
- "setup $k");
- }
+ open $fh, '>>', $pi_config or die;
+ print $fh <<EOF or die;
+[publicinbox "test"]
+ address = $addr
+ inboxdir = $maindir
+ url = http://example.com/test/
+ newsgroup = inbox.test
+EOF
+ close $fh or die;
# ensure successful message delivery
{
^ permalink raw reply related [relevance 15%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-05 0:06 15% [PATCH] tests: remove some "git config" calls after "git init" Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).