* Re: [PATCH 3/3] tests: check-run: show skipped tests
2020-08-28 10:13 6% ` [PATCH 3/3] tests: check-run: show skipped tests Eric Wong
@ 2020-08-28 22:18 7% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2020-08-28 22:18 UTC (permalink / raw)
To: meta
Eric Wong <e@yhbt.net> wrote:
> + my %nr;
> + $nr{$_}++ for @sk;
> + for (@sk) {
> + my $n = delete $nr{$_} or next;
> + print OLDERR "$pfx$_ ($n)\n";
> + }
That's longer than it needs to be, we can grep here, too.
diff --git a/t/run.perl b/t/run.perl
index e3e3e075..0ba5e044 100755
--- a/t/run.perl
+++ b/t/run.perl
@@ -80,11 +80,8 @@ sub test_status () {
my @sk = (<$fh> =~ m/^ok [0-9]+ (# skip [^\n]+)/mgs);
if (@sk) {
my %nr;
- $nr{$_}++ for @sk;
- for (@sk) {
- my $n = delete $nr{$_} or next;
- print OLDERR "$pfx$_ ($n)\n";
- }
+ my @err = grep { !$nr{$_}++ } @sk;
+ print OLDERR "$pfx$_ ($nr{$_})\n" for @err;
$skip = ' # total skipped: '.scalar(@sk);
}
} else {
^ permalink raw reply related [relevance 7%]
* [PATCH 3/3] tests: check-run: show skipped tests
2020-08-28 10:12 5% [PATCH 0/3] more watch-related stuff Eric Wong
@ 2020-08-28 10:13 6% ` Eric Wong
2020-08-28 22:18 7% ` Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2020-08-28 10:13 UTC (permalink / raw)
To: meta
We'll deduplicate redundant lines and show counts of skipped
tests to ensure it's easy to notice if something is unexpectedly
skipped.
---
t/run.perl | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/t/run.perl b/t/run.perl
index b1a0d2fe..e3e3e075 100755
--- a/t/run.perl
+++ b/t/run.perl
@@ -15,6 +15,7 @@ use PublicInbox::TestCommon;
use Cwd qw(getcwd);
use Getopt::Long qw(:config gnu_getopt no_ignore_case auto_abbrev);
use Errno qw(EINTR);
+use Fcntl qw(:seek);
use POSIX qw(_POSIX_PIPE_BUF WNOHANG);
my $jobs = 1;
my $repeat = 1;
@@ -65,14 +66,31 @@ sub test_status () {
if ($log_suffix ne '') {
my $log = $worker_test;
$log =~ s/\.t\z/$log_suffix/;
+ my $skip = '';
if (open my $fh, '<', $log) {
my @not_ok = grep(!/^(?:ok |[ \t]*#)/ms, <$fh>);
pop @not_ok if $not_ok[-1] =~ /^[0-9]+\.\.[0-9]+$/;
- print OLDERR map { "# $log: $_" } @not_ok;
+ my $pfx = "# $log: ";
+ print OLDERR map { $pfx.$_ } @not_ok;
+ seek($fh, 0, SEEK_SET) or die "seek: $!";
+
+ # show unique skip texts and the number of times
+ # each text was skipped
+ local $/;
+ my @sk = (<$fh> =~ m/^ok [0-9]+ (# skip [^\n]+)/mgs);
+ if (@sk) {
+ my %nr;
+ $nr{$_}++ for @sk;
+ for (@sk) {
+ my $n = delete $nr{$_} or next;
+ print OLDERR "$pfx$_ ($n)\n";
+ }
+ $skip = ' # total skipped: '.scalar(@sk);
+ }
} else {
print OLDERR "could not open: $log: $!\n";
}
- print OLDOUT "$status $worker_test\n";
+ print OLDOUT "$status $worker_test$skip\n";
}
}
^ permalink raw reply related [relevance 6%]
* [PATCH 0/3] more watch-related stuff
@ 2020-08-28 10:12 5% Eric Wong
2020-08-28 10:13 6% ` [PATCH 3/3] tests: check-run: show skipped tests Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2020-08-28 10:12 UTC (permalink / raw)
To: meta
1/3 is the most important; more watch tweaks coming...
Eric Wong (3):
watch: flush changes to inbox before updating IMAPTracker
imaptracker: update_last: simplify callers
tests: check-run: show skipped tests
lib/PublicInbox/IMAPTracker.pm | 5 +++--
lib/PublicInbox/WatchMaildir.pm | 4 ++--
t/run.perl | 22 ++++++++++++++++++++--
3 files changed, 25 insertions(+), 6 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-08-28 10:12 5% [PATCH 0/3] more watch-related stuff Eric Wong
2020-08-28 10:13 6% ` [PATCH 3/3] tests: check-run: show skipped tests Eric Wong
2020-08-28 22:18 7% ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).