* [PATCHv2 2/1] test_common: eliminate call to non-existent cleanup_task
@ 2023-09-14 20:52 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2023-09-14 20:52 UTC (permalink / raw)
To: meta
cleanup_task is long gone since all that cleanup work got moved
into DS itself. Adding a DS->Reset here breaks t/imapd.t (and
possibly other tests), and is actually unlikely to avoid any
cleanup segfaults on OpenBSD since those are only happening
after `END {}' blocks are called.
---
Original 2/1 patch broke t/imapd.t :x
lib/PublicInbox/TestCommon.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index a8323e4d..4c819a4f 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -365,7 +365,8 @@ sub run_script ($;$$) {
chdir $d or die "chdir $d: $!";
}
_run_sub($sub, $key, \@argv);
- eval { PublicInbox::Inbox::cleanup_task() };
+ # n.b. all our uses of PublicInbox::DS should be fine
+ # with this and we can't Reset here.
die "fchdir(restore): $!" if $cwdfh && !chdir($cwdfh);
_undo_redirects($orig_io);
select STDOUT;
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-09-14 12:50 [PATCH] ds: Reset at END Eric Wong
2023-09-14 13:02 ` [PATCH 2/1] test_common: call DS->Reset instead of cleanup_task Eric Wong
2023-09-14 20:52 7% ` [PATCHv2 2/1] test_common: eliminate call to non-existent cleanup_task Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).