* [PATCH] tail_notify: cleanups and wakeup avoidance
@ 2023-07-14 20:35 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2023-07-14 20:35 UTC (permalink / raw)
To: meta
Avoid adding redundant watches at initialization, and avoid
unnecessarily wake ups when no timeout is specified.
---
lib/PublicInbox/TailNotify.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/TailNotify.pm b/lib/PublicInbox/TailNotify.pm
index a0347aa5..cbbc1041 100644
--- a/lib/PublicInbox/TailNotify.pm
+++ b/lib/PublicInbox/TailNotify.pm
@@ -43,7 +43,6 @@ sub new {
} else {
$self->{inot} = PublicInbox::FakeInotify->new;
}
- $self->{inot}->watch($fn, $TAIL_MOD);
reopen_file($self);
$self->{inot}->watch($fn, $TAIL_MOD);
$self;
@@ -64,6 +63,8 @@ again:
if (defined $end) {
$wait = $end - now;
$wait = 0 if $wait < 0;
+ } else {
+ undef $wait;
}
}
select($rfds, undef, undef, $wait);
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-07-14 20:35 7% [PATCH] tail_notify: cleanups and wakeup avoidance Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).