* [PATCH] t/httpd-unix.t: avoid race in between bind() and listen()
@ 2019-06-30 22:32 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2019-06-30 22:32 UTC (permalink / raw)
To: meta
We need to be able to successfully connect() to the socket
before attempting further tests. Merely testing for the
existence of a socket isn't enough, since the server may've
only done bind(), not listen().
---
t/httpd-unix.t | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/httpd-unix.t b/t/httpd-unix.t
index db652479..4fe2d1eb 100644
--- a/t/httpd-unix.t
+++ b/t/httpd-unix.t
@@ -42,8 +42,9 @@ my $spawn_httpd = sub {
ok(!-S $unix, 'UNIX socket does not exist, yet');
$spawn_httpd->("-l$unix");
+my %o = (Peer => $unix, Type => SOCK_STREAM);
for (1..1000) {
- last if -S $unix;
+ last if -S $unix && IO::Socket::UNIX->new(%o);
select undef, undef, undef, 0.02
}
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-06-30 22:32 7% [PATCH] t/httpd-unix.t: avoid race in between bind() and listen() Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).