* [PATCH 0/9] more small fixes and cleanups
@ 2020-01-11 22:34 5% Eric Wong
2020-01-11 22:35 7% ` [PATCH 8/9] t/solver_git: avoid uninitialized warnings in hostname generation Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-11 22:34 UTC (permalink / raw)
To: meta
One bugfix for solver, a couple of optimizations which will
make sense when dealing with many and larger code repos.
And some cleanups to reduce redundant code.
Eric Wong (9):
config: do not slurp entire cgitrc at once
git: modified: don't slurp `rev-parse --branches'
git: packed_bytes: use GLOB_NOSORT
solver: path_a may be undef from /dev/null
cgit: drop cgit_parse_hdr wrapper
xapcmd: use popen_rd for running xapian-compact
xt/git_async_cmp: do not slurp large OID list into memory
t/solver_git: avoid uninitialized warnings in hostname generation
use popen_rd for bidirectional pipes
lib/PublicInbox/Cgit.pm | 9 ++-------
lib/PublicInbox/Config.pm | 4 ++--
lib/PublicInbox/Git.pm | 24 +++++++++++-------------
lib/PublicInbox/Import.pm | 8 +++-----
lib/PublicInbox/SolverGit.pm | 4 ++--
lib/PublicInbox/V2Writable.pm | 11 +++--------
lib/PublicInbox/Xapcmd.pm | 16 +++++-----------
t/solver_git.t | 12 ++++++------
xt/git_async_cmp.t | 4 ++--
9 files changed, 36 insertions(+), 56 deletions(-)
DELETE! DELETE! DELETE!
^ permalink raw reply [relevance 5%]
* [PATCH 8/9] t/solver_git: avoid uninitialized warnings in hostname generation
2020-01-11 22:34 5% [PATCH 0/9] more small fixes and cleanups Eric Wong
@ 2020-01-11 22:35 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-11 22:35 UTC (permalink / raw)
To: meta
Outside of tests, this is only relevant for non-PSGI use, which
may happen someday...
Fixes: cb1c874520153f5c ("inbox: use PublicInbox::Git::host_prefix_url for base_url")
---
t/solver_git.t | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/solver_git.t b/t/solver_git.t
index 77fa1e09..98317fae 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -42,7 +42,8 @@ $ibx->{-repo_objs} = [ $git ];
my $res;
my $solver = PublicInbox::SolverGit->new($ibx, sub { $res = $_[0] });
open my $log, '+>>', "$inboxdir/solve.log" or die "open: $!";
-my $psgi_env = { 'psgi.errors' => *STDERR, 'psgi.url_scheme' => 'http' };
+my $psgi_env = { 'psgi.errors' => *STDERR, 'psgi.url_scheme' => 'http',
+ 'HTTP_HOST' => 'example.com' };
$solver->solve($psgi_env, $log, '69df7d5', {});
ok($res, 'solved a blob!');
my $wt_git = $res->[0];
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-11 22:34 5% [PATCH 0/9] more small fixes and cleanups Eric Wong
2020-01-11 22:35 7% ` [PATCH 8/9] t/solver_git: avoid uninitialized warnings in hostname generation Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).