user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 1/7] t/nntpd.t: fix fcntl test to ensure no failures
  2015-09-22 10:09  4% [PATCH 0/7] nntp: another round of updates Eric Wong
@ 2015-09-22 10:09  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-09-22 10:09 UTC (permalink / raw)
  To: meta

We need to run the syscall before testing for its failure :x
---
 t/nntpd.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/nntpd.t b/t/nntpd.t
index d30ed63..d886e3c 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -88,8 +88,8 @@ EOF
 	}
 	ok(defined $pid, 'forked nntpd process successfully');
 	$! = 0;
-	ok(! $!, 'no error from fcntl(F_SETFD)');
 	fcntl($sock, F_SETFD, $fl |= FD_CLOEXEC);
+	ok(! $!, 'no error from fcntl(F_SETFD)');
 	my $n = Net::NNTP->new($sock->sockhost . ':' . $sock->sockport);
 	my $list = $n->list;
 	is_deeply($list, { $group => [ qw(1 1 n) ] }, 'LIST works');
-- 
EW


^ permalink raw reply related	[relevance 7%]

* [PATCH 0/7] nntp: another round of updates
@ 2015-09-22 10:09  4% Eric Wong
  2015-09-22 10:09  7% ` [PATCH 1/7] t/nntpd.t: fix fcntl test to ensure no failures Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2015-09-22 10:09 UTC (permalink / raw)
  To: meta

I guess we'll implement RFC 3977 before we commit to a extending
fields needed for an overview database...

Eric Wong (7):
      t/nntpd.t: fix fcntl test to ensure no failures
      nntp: support YYYYMMDD dates for commands
      nntp: ensure body lines end with CRLF
      nntp: avoid setting Bytes and Lines headers
      nntp: implement OVER from RFC 3977
      nntp: XHDR fixes for Message-ID lookups
      nntp: XHDR lookups by Message-ID may cross groups

 lib/PublicInbox/NNTP.pm | 136 ++++++++++++++++++++++++++++++++----------------
 t/nntp.t                |  29 +++++++++++
 t/nntpd.t               |  30 ++++++++++-
 3 files changed, 147 insertions(+), 48 deletions(-)

^ permalink raw reply	[relevance 4%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-09-22 10:09  4% [PATCH 0/7] nntp: another round of updates Eric Wong
2015-09-22 10:09  7% ` [PATCH 1/7] t/nntpd.t: fix fcntl test to ensure no failures Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).