* [PATCH 4/6] t/cgi.t: move dumb HTTP git clone/fetch tests to plack.t
2019-01-04 13:10 5% [PATCH 0/6] t/cgi.t: test speedups and cleanups Eric Wong
@ 2019-01-04 13:10 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-01-04 13:10 UTC (permalink / raw)
To: meta
No need to test this via CGI .cgi is a wrapper around
PSGI and PSGI tests are way faster.
---
t/cgi.t | 19 -------------------
t/plack.t | 20 ++++++++++++++++++++
2 files changed, 20 insertions(+), 19 deletions(-)
diff --git a/t/cgi.t b/t/cgi.t
index 382c21f..a25d2ee 100644
--- a/t/cgi.t
+++ b/t/cgi.t
@@ -90,25 +90,6 @@ EOF
like($res->{head}, qr/Status:\s*404/i, "index returns 404");
}
-# dumb HTTP support
-{
- local $ENV{HOME} = $home;
- my $path = "/test/info/refs";
- my $res = cgi_run($path);
- like($res->{head}, qr/Status:\s*200/i, "info/refs readable");
- my $orig = $res->{body};
-
- local $ENV{HTTP_RANGE} = 'bytes=5-10';
- $res = cgi_run($path);
- like($res->{head}, qr/Status:\s*206/i, "info/refs partial OK");
- is($res->{body}, substr($orig, 5, 6), 'partial body OK');
-
- local $ENV{HTTP_RANGE} = 'bytes=5-';
- $res = cgi_run($path);
- like($res->{head}, qr/Status:\s*206/i, "info/refs partial past end OK");
- is($res->{body}, substr($orig, 5), 'partial body OK past end');
-}
-
# message-id pages
{
local $ENV{HOME} = $home;
diff --git a/t/plack.t b/t/plack.t
index 1a719b4..14c9b65 100644
--- a/t/plack.t
+++ b/t/plack.t
@@ -220,6 +220,26 @@ EOF
'redirect from x40 MIDs works');
}
});
+
+ # dumb HTTP clone/fetch support
+ test_psgi($app, sub {
+ my ($cb) = @_;
+ my $path = '/test/info/refs';
+ my $req = HTTP::Request->new('GET' => $path);
+ my $res = $cb->($req);
+ is(200, $res->code, 'refs readable');
+ my $orig = $res->content;
+
+ $req->header('Range', 'bytes=5-10');
+ $res = $cb->($req);
+ is(206, $res->code, 'got partial response');
+ is($res->content, substr($orig, 5, 6), 'partial body OK');
+
+ $req->header('Range', 'bytes=5-');
+ $res = $cb->($req);
+ is(206, $res->code, 'got partial another response');
+ is($res->content, substr($orig, 5), 'partial body OK past end');
+ });
}
done_testing();
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/6] t/cgi.t: test speedups and cleanups
@ 2019-01-04 13:10 5% Eric Wong
2019-01-04 13:10 7% ` [PATCH 4/6] t/cgi.t: move dumb HTTP git clone/fetch tests to plack.t Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-01-04 13:10 UTC (permalink / raw)
To: meta
While we relied on CGI.pm early in the project, we've moved onto PSGI
and relied on PSGI for providing CGI compatibility. Thus, most of our
CGI-based tests are redundant and Perl startup overhead is painful.
On my system, this cuts the t/cgi.t from 4.4s to 1.8s for a nice
improvement. Moving some tests to t/plack.t did not increase runtimes
in a meaningful way.
Eric Wong (6):
t/cgi.t: eliminate some cruft and unnecessary tests
t/cgi.t: remove redundant redirect check
t/cgi.t: remove atom.xml test
t/cgi.t: move dumb HTTP git clone/fetch tests to plack.t
t/cgi.t: move expected failure tests to t/plack.t
t/cgi.t: remove more redundant tests
t/cgi.t | 105 ++++++++----------------------------------------------
t/plack.t | 43 ++++++++++++++++++++--
2 files changed, 54 insertions(+), 94 deletions(-)
--
EW
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-01-04 13:10 5% [PATCH 0/6] t/cgi.t: test speedups and cleanups Eric Wong
2019-01-04 13:10 7% ` [PATCH 4/6] t/cgi.t: move dumb HTTP git clone/fetch tests to plack.t Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).