* [PATCH 1/6] searchview: factor out dump_mset subroutine
@ 2015-09-05 9:01 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2015-09-05 9:01 UTC (permalink / raw)
To: meta
We'll be moving atom and thread display support inline
and reducing endpoints. Maybe it makes sense, maybe not.
---
lib/PublicInbox/SearchView.pm | 41 ++++++++++++++++++++---------------------
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 4d49d25..960049f 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -49,23 +49,7 @@ sub sres_top_html {
}
$res .= "]\n\n";
- my $pad = length("$total");
- my $pfx = ' ' x $pad;
- foreach my $m ($mset->items) {
- my $rank = sprintf("%${pad}d", $m->get_rank + 1);
- my $pct = $m->get_percent;
- my $smsg = $m->get_document;
- $smsg = PublicInbox::SearchMsg->load_doc($smsg);
- my $s = PublicInbox::Hval->new_oneline($smsg->subject);
- my $f = $smsg->from_name;
- $f = PublicInbox::Hval->new_oneline($f)->as_html;
- my $d = strftime('%Y-%m-%d %H:%M', gmtime($smsg->ts));
- my $mid = $smsg->mid;
- $mid = PublicInbox::Hval->new_msgid($mid)->as_href;
- $res .= qq{$rank. <b><a\nhref="$mid/t/#u">}.
- $s->as_html . "</a></b>\n";
- $res .= "$pfx - by $f @ $d UTC [$pct%]\n\n";
- }
+ dump_mset(\$res, $mset);
my $nr = scalar $mset->items;
my $end = $o + $nr;
my $beg = $o + 1;
@@ -86,17 +70,32 @@ sub sres_top_html {
$qp .= "&r" if $r;
$res .= qq{<a\nhref="?$qp">prev</a>};
}
- $res .= "\n\n".$foot;
+ $res .= "\n\n" . $foot;
}
$res .= "</pre></body></html>";
[200, ['Content-Type'=>'text/html; charset=UTF-8'], [$res]];
}
-sub sres_top_atom {
-}
+sub dump_mset {
+ my ($res, $mset) = @_;
-sub sres_top_thread {
+ my $total = $mset->get_matches_estimated;
+ my $pad = length("$total");
+ my $pfx = ' ' x $pad;
+ foreach my $m ($mset->items) {
+ my $rank = sprintf("%${pad}d", $m->get_rank + 1);
+ my $pct = $m->get_percent;
+ my $smsg = PublicInbox::SearchMsg->load_doc($m->get_document);
+ my $s = PublicInbox::Hval->new_oneline($smsg->subject);
+ my $f = $smsg->from_name;
+ $f = PublicInbox::Hval->new_oneline($f)->as_html;
+ my $d = strftime('%Y-%m-%d %H:%M', gmtime($smsg->ts));
+ my $mid = PublicInbox::Hval->new_msgid($smsg->mid)->as_href;
+ $$res .= qq{$rank. <b><a\nhref="$mid/t/#u">}.
+ $s->as_html . "</a></b>\n";
+ $$res .= "$pfx - by $f @ $d UTC [$pct%]\n\n";
+ }
}
1;
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-09-05 9:01 [PATCH 0/6] another round of search updates Eric Wong
2015-09-05 9:01 7% ` [PATCH 1/6] searchview: factor out dump_mset subroutine Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).