We will occasionally see legit messages with zero lines, be sure we index that count for NNTP clients. I'm not sure about bytes being zero (aside from purged messages), but we should've dealt with that earlier up the stack. --- lib/PublicInbox/SearchMsg.pm | 4 ++-- t/v2mirror.t | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm index 42384936..84fe4802 100644 --- a/lib/PublicInbox/SearchMsg.pm +++ b/lib/PublicInbox/SearchMsg.pm @@ -42,8 +42,8 @@ sub to_doc_data { $self->cc, $oid, $mid0, - $self->{bytes} || '', - $self->{lines} || '' + $self->{bytes} // '', + $self->{lines} // '' ); } diff --git a/t/v2mirror.t b/t/v2mirror.t index dc930d90..2e23e763 100644 --- a/t/v2mirror.t +++ b/t/v2mirror.t @@ -55,6 +55,11 @@ for my $i (1..9) { my $epoch_max = $v2w->{epoch_max}; ok($epoch_max > 0, "multiple epochs"); $v2w->done; +{ + my $smsg = $ibx->over->get_art(1); + like($smsg->{lines}, qr/\A[0-9]+\z/, 'lines is a digit'); + like($smsg->{bytes}, qr/\A[0-9]+\z/, 'bytes is a digit'); +} $ibx->cleanup; my $sock = tcp_server();