* [PATCH 2/2] nntp: use lookup_mail instead of lookup_message
2016-06-20 7:22 5% [PATCH 0/2] better ghost handling Eric Wong
@ 2016-06-20 7:22 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-20 7:22 UTC (permalink / raw)
To: meta
lookup_mail is safer since it won't inadvertently load ghosts.
---
lib/PublicInbox/NNTP.pm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 93f654f..4b116a7 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -711,8 +711,7 @@ sub hdr_xref ($$$) { # optimize XHDR Xref [range] for rtin
sub search_header_for {
my ($srch, $mid, $field) = @_;
- my $smsg = $srch->lookup_message($mid) or return;
- $smsg = PublicInbox::SearchMsg->load_doc($smsg->{doc});
+ my $smsg = $srch->lookup_mail($mid) or return;
$smsg->$field;
}
@@ -847,10 +846,9 @@ sub cmd_over ($;$) {
my ($self, $range) = @_;
if ($range && $range =~ /\A<(.+)>\z/) {
my ($ng, $n) = mid_lookup($self, $1);
- my $smsg = $ng->search->lookup_message($range) or
+ my $smsg = $ng->search->lookup_mail($range) or
return '430 No article with that message-id';
more($self, '224 Overview information follows (multi-line)');
- $smsg = PublicInbox::SearchMsg->load_doc($smsg->{doc});
# Only set article number column if it's the current group
my $self_ng = $self->{ng};
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] better ghost handling
@ 2016-06-20 7:22 5% Eric Wong
2016-06-20 7:22 7% ` [PATCH 2/2] nntp: use lookup_mail instead of lookup_message Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-06-20 7:22 UTC (permalink / raw)
To: meta
Improve the handling of ghosts in the WWW topic view;
which lead me to a related NNTP cleanup.
Eric Wong (2):
www: improve topic view by scanning for ghosts
nntp: use lookup_mail instead of lookup_message
lib/PublicInbox/NNTP.pm | 6 ++----
lib/PublicInbox/Search.pm | 6 ++++++
lib/PublicInbox/SearchMsg.pm | 2 +-
lib/PublicInbox/View.pm | 14 +++++++++++---
4 files changed, 20 insertions(+), 8 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-20 7:22 5% [PATCH 0/2] better ghost handling Eric Wong
2016-06-20 7:22 7% ` [PATCH 2/2] nntp: use lookup_mail instead of lookup_message Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).