* [PATCH 1/2] mid: rename MID_MAX to ID_MAX
2020-09-15 19:51 6% [PATCH 0/2] remove more 40 char limits Eric Wong
@ 2020-09-15 19:51 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-09-15 19:51 UTC (permalink / raw)
To: meta
It's only used for HTML anchors which we will need indefinitely.
---
lib/PublicInbox/MID.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/MID.pm b/lib/PublicInbox/MID.pm
index e9a3b0c0..369bb034 100644
--- a/lib/PublicInbox/MID.pm
+++ b/lib/PublicInbox/MID.pm
@@ -12,7 +12,7 @@ use URI::Escape qw(uri_escape_utf8);
use Digest::SHA qw/sha1_hex/;
require PublicInbox::Address;
use constant {
- MID_MAX => 40, # SHA-1 hex length # TODO: get rid of this
+ ID_MAX => 40, # SHA-1 hex length for HTML id anchors
MAX_MID_SIZE => 244, # max term size (Xapian limitation) - length('Q')
};
@@ -32,7 +32,7 @@ sub mid_clean {
sub id_compress {
my ($id, $force) = @_;
- if ($force || $id =~ /[^a-zA-Z0-9_\-]/ || length($id) > MID_MAX) {
+ if ($force || $id =~ /[^a-zA-Z0-9_\-]/ || length($id) > ID_MAX) {
utf8::encode($id);
return sha1_hex($id);
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] remove more 40 char limits
@ 2020-09-15 19:51 6% Eric Wong
2020-09-15 19:51 7% ` [PATCH 1/2] mid: rename MID_MAX to ID_MAX Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-09-15 19:51 UTC (permalink / raw)
To: meta
SHA-256 support is coming in git
Eric Wong (2):
mid: rename MID_MAX to ID_MAX
treewide: relax allow >=40 chars for git OID
lib/PublicInbox/Feed.pm | 4 ++--
lib/PublicInbox/Git.pm | 2 +-
lib/PublicInbox/Import.pm | 4 ++--
lib/PublicInbox/MID.pm | 4 ++--
lib/PublicInbox/ViewDiff.pm | 4 ++--
lib/PublicInbox/WWW.pm | 2 +-
t/edit.t | 4 ++--
t/plack.t | 2 +-
t/replace.t | 2 +-
t/v2writable.t | 4 ++--
10 files changed, 16 insertions(+), 16 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-09-15 19:51 6% [PATCH 0/2] remove more 40 char limits Eric Wong
2020-09-15 19:51 7% ` [PATCH 1/2] mid: rename MID_MAX to ID_MAX Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).