user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 3/4] lei_inspect: fix typo
  2021-07-25  0:43  7% [PATCH 0/4] favor shorter binary OID comparisons Eric Wong
@ 2021-07-25  0:43  6% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-07-25  0:43 UTC (permalink / raw)
  To: meta

Not sure how this wasn't caught, earlier...
---
 lib/PublicInbox/LeiInspect.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/LeiInspect.pm b/lib/PublicInbox/LeiInspect.pm
index 574da7a7..c277520c 100644
--- a/lib/PublicInbox/LeiInspect.pm
+++ b/lib/PublicInbox/LeiInspect.pm
@@ -74,7 +74,7 @@ sub inspect_docid ($$;$) {
 	my $data = $doc->get_data;
 	$ent->{docid} = $docid;
 	$ent->{data_length} = length($data);
-	$ent->{description} => $doc->get_description;
+	$ent->{description} = $doc->get_description;
 	$ent->{$_} = $doc->$_ for (qw(termlist_count values_count));
 	my $cur = $doc->termlist_begin;
 	my $end = $doc->termlist_end;

^ permalink raw reply related	[relevance 6%]

* [PATCH 0/4] favor shorter binary OID comparisons
@ 2021-07-25  0:43  7% Eric Wong
  2021-07-25  0:43  6% ` [PATCH 3/4] lei_inspect: fix typo Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-07-25  0:43 UTC (permalink / raw)
  To: meta

We were doing unneccessary 40-byte hex comparisons for SHA-1s
in our code when 20-byte comparisons would've been sufficient.
3/4 is a typo fix which didn't hit any warnings before,
either...

Eric Wong (4):
  extsearchidx: favor binary comparison in common case
  lei_search: favor binary OID comparisons
  lei_inspect: fix typo
  lei_mail_sync: locations_for API uses oidbin for comparisons

 lib/PublicInbox/ExtSearchIdx.pm | 4 ++--
 lib/PublicInbox/LeiExportKw.pm  | 7 +++----
 lib/PublicInbox/LeiInspect.pm   | 7 ++++---
 lib/PublicInbox/LeiMailSync.pm  | 7 ++++---
 lib/PublicInbox/LeiSearch.pm    | 6 +++---
 t/lei_mail_sync.t               | 4 ++--
 6 files changed, 18 insertions(+), 17 deletions(-)

^ permalink raw reply	[relevance 7%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-07-25  0:43  7% [PATCH 0/4] favor shorter binary OID comparisons Eric Wong
2021-07-25  0:43  6% ` [PATCH 3/4] lei_inspect: fix typo Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).