* [PATCH 1/2] lei_input: give a hint for upper-case in labels
2023-01-29 22:58 4% [PATCH 0/2] fix xt/lei-auth-fail.t Eric Wong
@ 2023-01-29 22:58 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-01-29 22:58 UTC (permalink / raw)
To: meta
I just encountered this error in xt/lei-auth-fail.t
---
lib/PublicInbox/LeiInput.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/PublicInbox/LeiInput.pm b/lib/PublicInbox/LeiInput.pm
index c258f824..b6c2b6bb 100644
--- a/lib/PublicInbox/LeiInput.pm
+++ b/lib/PublicInbox/LeiInput.pm
@@ -30,6 +30,8 @@ my %ERR = (
my ($label) = @_;
length($label) >= $L_MAX and
return "`$label' too long (must be <= $L_MAX)";
+ $label =~ /[A-Z]/ and
+ return "`$label' must be lowercase";
$label =~ m{\A[a-z0-9_](?:[a-z0-9_\-\./\@,]*[a-z0-9])?\z} ?
undef : "`$label' is invalid";
},
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] fix xt/lei-auth-fail.t
@ 2023-01-29 22:58 4% Eric Wong
2023-01-29 22:58 7% ` [PATCH 1/2] lei_input: give a hint for upper-case in labels Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-01-29 22:58 UTC (permalink / raw)
To: meta
I need a failing mock IMAP server for this, or remember xt/ exists :<
Eric Wong (2):
lei_input: give a hint for upper-case in labels
xt/lei-auth-fail: use valid label name
lib/PublicInbox/LeiInput.pm | 2 ++
xt/lei-auth-fail.t | 7 ++++---
2 files changed, 6 insertions(+), 3 deletions(-)
^ permalink raw reply [relevance 4%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-01-29 22:58 4% [PATCH 0/2] fix xt/lei-auth-fail.t Eric Wong
2023-01-29 22:58 7% ` [PATCH 1/2] lei_input: give a hint for upper-case in labels Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).