* Re: [PATCH] lei rediff: handle stdin like other commands
2021-05-16 2:42 8% [PATCH] lei rediff: handle stdin like other commands Kyle Meyer
@ 2021-05-16 15:23 14% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-05-16 15:23 UTC (permalink / raw)
To: Kyle Meyer; +Cc: meta
Thanks, pushed your 3 patches as:
8cc23ac6 lei rediff: handle stdin like other commands
2c1cbdc7 lei rediff: mark --color-moved value as optional
1110da3e lei_input: drop misplaced word from error message
^ permalink raw reply [relevance 14%]
* [PATCH] lei rediff: handle stdin like other commands
@ 2021-05-16 2:42 8% Kyle Meyer
2021-05-16 15:23 14% ` Eric Wong
0 siblings, 1 reply; 2+ results
From: Kyle Meyer @ 2021-05-16 2:42 UTC (permalink / raw)
To: meta
`lei rediff' reads from stdin when no argument is specified, but this
is likely unintentional given that other lei commands instead have a
--stdin|- option and that `lei rediff --help' includes --stdin.
Align rediff's handling with the other commands'.
---
lib/PublicInbox/LEI.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm
index 5f178418..2144e390 100644
--- a/lib/PublicInbox/LEI.pm
+++ b/lib/PublicInbox/LEI.pm
@@ -180,8 +180,9 @@ our %CMD = ( # sorted in order of importance/use:
qw(git-dir=s@ cwd! verbose|v+ mail! oid-a|A=s path-a|a=s path-b|b=s),
@lxs_opt, @c_opt ],
-'rediff' => [ '[--stdin|LOCATION...]',
+'rediff' => [ '--stdin|LOCATION...',
'regenerate a diff with different options',
+ 'stdin|', # /|\z/ must be first for lone dash
qw(git-dir=s@ cwd! verbose|v+ color:s no-color),
@diff_opt, @lxs_opt, @c_opt ],
base-commit: 79e274b293a71fb41dd8bf6e9598a8e8a24fed4f
--
2.31.1
^ permalink raw reply related [relevance 8%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-05-16 2:42 8% [PATCH] lei rediff: handle stdin like other commands Kyle Meyer
2021-05-16 15:23 14% ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).