user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 3/7] inboxwritable: import_maildir uses maildir_path_load
  2019-10-21 11:22  5% [PATCH 0/7] dead code elimination Eric Wong
@ 2019-10-21 11:22  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-10-21 11:22 UTC (permalink / raw)
  To: meta

I'm not sure if this will get used anywhere, but at least
call a function which exists in dead code.
---
 lib/PublicInbox/InboxWritable.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/InboxWritable.pm b/lib/PublicInbox/InboxWritable.pm
index 174e4245..ab7b0ed5 100644
--- a/lib/PublicInbox/InboxWritable.pm
+++ b/lib/PublicInbox/InboxWritable.pm
@@ -134,7 +134,7 @@ sub import_maildir {
 		opendir my $dh, "$dir/$sub" or die "opendir $dir/$sub: $!\n";
 		while (defined(my $fn = readdir($dh))) {
 			next unless is_maildir_basename($fn);
-			my $mime = maildir_file_load("$dir/$fn") or next;
+			my $mime = maildir_path_load("$dir/$fn") or next;
 
 			if (my $filter = $self->filter($im)) {
 				my $ret = $filter->scrub($mime) or return;

^ permalink raw reply related	[relevance 7%]

* [PATCH 0/7] dead code elimination
@ 2019-10-21 11:22  5% Eric Wong
  2019-10-21 11:22  7% ` [PATCH 3/7] inboxwritable: import_maildir uses maildir_path_load Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-10-21 11:22 UTC (permalink / raw)
  To: meta

I noticed OverIdx->delete_articles was unused while
working on the --reindex bug with multiple Message-IDs,
and went looking for more dead code.

This should make release tarballs smaller, at least.

Eric Wong (7):
  overidx: remove unused delete_articles sub
  www: remove unused ctx_get sub
  inboxwritable: import_maildir uses maildir_path_load
  watchmaildir: remove redundant _path_to_mime
  git: remove src_blob_url
  hval: remove new_oneline
  syscall: get rid of sendfile wrappers for now

 lib/PublicInbox/Git.pm           | 11 -----
 lib/PublicInbox/Hval.pm          |  8 ----
 lib/PublicInbox/InboxWritable.pm |  2 +-
 lib/PublicInbox/OverIdx.pm       |  6 ---
 lib/PublicInbox/Syscall.pm       | 75 +-------------------------------
 lib/PublicInbox/WWW.pm           |  7 ---
 lib/PublicInbox/WatchMaildir.pm  | 20 ++-------
 7 files changed, 5 insertions(+), 124 deletions(-)

^ permalink raw reply	[relevance 5%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-10-21 11:22  5% [PATCH 0/7] dead code elimination Eric Wong
2019-10-21 11:22  7% ` [PATCH 3/7] inboxwritable: import_maildir uses maildir_path_load Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).