* [PATCH] inbox: allow undef return value for base_url
@ 2016-06-15 1:31 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-06-15 1:31 UTC (permalink / raw)
To: meta
It should be possible to serve the contents of a public-inbox
over NNTP but not HTTP.
---
lib/PublicInbox/Inbox.pm | 2 +-
t/inbox.t | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 27218de..c982d0b 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -73,7 +73,7 @@ sub base_url {
} else {
# either called from a non-PSGI environment (e.g. NNTP/POP3)
$self->{-base_url} ||= do {
- my $url = $self->{url};
+ my $url = $self->{url} or return undef;
# expand protocol-relative URLs to HTTPS if we're
# not inside a web server
$url = "https:$url" if $url =~ m!\A//!;
diff --git a/t/inbox.t b/t/inbox.t
index 45ba1df..9909dc5 100644
--- a/t/inbox.t
+++ b/t/inbox.t
@@ -9,4 +9,7 @@ is($x->base_url, 'https://example.com/test/', 'expanded protocol-relative');
$x = PublicInbox::Inbox->new({url => 'http://example.com/test'});
is($x->base_url, 'http://example.com/test/', 'added trailing slash');
+$x = PublicInbox::Inbox->new({});
+is($x->base_url, undef, 'undef base_url allowed');
+
done_testing();
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-15 1:31 7% [PATCH] inbox: allow undef return value for base_url Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).