* [PATCH 5/7] imap: ensure_slices_exist: drop needless map and array
2022-08-04 8:16 6% [PATCH 0/7] various op/allocation golfing Eric Wong
@ 2022-08-04 8:17 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-08-04 8:17 UTC (permalink / raw)
To: meta
We can reduce ops and temporary objects here by folding the
stringification into the `for' loop and push directly into the
{mailboxlist} array; relying on autovivification to turn it into
a noop for the initial population.
---
lib/PublicInbox/IMAP.pm | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index 9955984b..bed633e5 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -354,17 +354,14 @@ sub ensure_slices_exist ($$) {
my ($imapd, $ibx) = @_;
my $mb_top = $ibx->{newsgroup} // return;
my $mailboxes = $imapd->{mailboxes};
- my @created;
+ my $list = $imapd->{mailboxlist}; # may be undef, just autoviv + noop
for (my $i = int($ibx->art_max/UID_SLICE); $i >= 0; --$i) {
my $sub_mailbox = "$mb_top.$i";
last if exists $mailboxes->{$sub_mailbox};
$mailboxes->{$sub_mailbox} = $ibx;
$sub_mailbox =~ s/\Ainbox\./INBOX./i; # more familiar to users
- push @created, $sub_mailbox;
+ push @$list, qq[* LIST (\\HasNoChildren) "." $sub_mailbox\r\n]
}
- return unless @created;
- my $l = $imapd->{mailboxlist} or return;
- push @$l, map { qq[* LIST (\\HasNoChildren) "." $_\r\n] } @created;
}
sub inbox_lookup ($$;$) {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] various op/allocation golfing
@ 2022-08-04 8:16 6% Eric Wong
2022-08-04 8:17 7% ` [PATCH 5/7] imap: ensure_slices_exist: drop needless map and array Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-08-04 8:16 UTC (permalink / raw)
To: meta
Nothing major, but some of these reduce Perl internal pad space,
which tends to add up across codebases with many cold paths.
Eric Wong (7):
http: coerce SERVER_PORT to integer
over: get_xref3: modify rows in-place
isearch: mset_to_artnums: avoid unnecessary ops
lei_overview: remove pointless map {} op
imap: ensure_slices_exist: drop needless map and array
feed: avoid unnecessary map loop in non-over path
view: avoid intermediate array when streaming thread
lib/PublicInbox/Feed.pm | 13 ++++++-------
lib/PublicInbox/HTTP.pm | 2 +-
lib/PublicInbox/IMAP.pm | 7 ++-----
lib/PublicInbox/Isearch.pm | 5 ++---
lib/PublicInbox/LeiOverview.pm | 2 +-
lib/PublicInbox/Over.pm | 8 ++++----
lib/PublicInbox/View.pm | 4 ++--
7 files changed, 18 insertions(+), 23 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-08-04 8:16 6% [PATCH 0/7] various op/allocation golfing Eric Wong
2022-08-04 8:17 7% ` [PATCH 5/7] imap: ensure_slices_exist: drop needless map and array Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).