* [PATCH 6/7] hval: remove new_oneline
2019-10-21 11:22 7% [PATCH 0/7] dead code elimination Eric Wong
@ 2019-10-21 11:22 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-10-21 11:22 UTC (permalink / raw)
To: meta
commit 476fc666c223f0fb ('reduce "PublicInbox::Hval->new_oneline" use')
was mis-titled, since it completely eliminated ->new_oneline use.
---
lib/PublicInbox/Hval.pm | 8 --------
1 file changed, 8 deletions(-)
diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 0e290601..c134e297 100644
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -32,14 +32,6 @@ sub new_msgid {
$class->new($msgid, mid_escape($msgid));
}
-sub new_oneline {
- my ($class, $raw) = @_;
- $raw = '' unless defined $raw;
- $raw =~ tr/\t\n / /s; # squeeze spaces
- $raw =~ tr/\r//d; # kill CR
- $class->new($raw);
-}
-
# some of these overrides are standard C escapes so they're
# easy-to-understand when rendered.
my %escape_sequence = (
^ permalink raw reply related [relevance 6%]
* [PATCH 0/7] dead code elimination
@ 2019-10-21 11:22 7% Eric Wong
2019-10-21 11:22 6% ` [PATCH 6/7] hval: remove new_oneline Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-10-21 11:22 UTC (permalink / raw)
To: meta
I noticed OverIdx->delete_articles was unused while
working on the --reindex bug with multiple Message-IDs,
and went looking for more dead code.
This should make release tarballs smaller, at least.
Eric Wong (7):
overidx: remove unused delete_articles sub
www: remove unused ctx_get sub
inboxwritable: import_maildir uses maildir_path_load
watchmaildir: remove redundant _path_to_mime
git: remove src_blob_url
hval: remove new_oneline
syscall: get rid of sendfile wrappers for now
lib/PublicInbox/Git.pm | 11 -----
lib/PublicInbox/Hval.pm | 8 ----
lib/PublicInbox/InboxWritable.pm | 2 +-
lib/PublicInbox/OverIdx.pm | 6 ---
lib/PublicInbox/Syscall.pm | 75 +-------------------------------
lib/PublicInbox/WWW.pm | 7 ---
lib/PublicInbox/WatchMaildir.pm | 20 ++-------
7 files changed, 5 insertions(+), 124 deletions(-)
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-10-21 11:22 7% [PATCH 0/7] dead code elimination Eric Wong
2019-10-21 11:22 6% ` [PATCH 6/7] hval: remove new_oneline Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).